TDE
/
tde-cmake
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

tde_create_translated_desktop: Incorporate a slightly modified version of intltool-merge #67

Merged
SlavekB merged 1 commits from feat/l10n-patched-intltool-merge into master 3 years ago
Conversation 1 Commits 1 Files Changed 2
SlavekB commented 3 years ago
Owner

For a solution implemented purely in CMake, it turned out that it would probably provide significantly lower performance. That's why I considered a solution in Perl. But because intltool-merge is written in Perl, there seems easier to make a small correction there than to reinvent the wheel. And to ensure that a patched version of intltool-merge is used, I've included it as part of our common CMake module.

What is your opinion on this?

For a solution implemented purely in CMake, it turned out that it would probably provide significantly lower performance. That's why I considered a solution in Perl. But because intltool-merge is written in Perl, there seems easier to make a small correction there than to reinvent the wheel. And to ensure that a patched version of intltool-merge is used, I've included it as part of our common CMake module. What is your opinion on this?
SlavekB added 1 commit 3 years ago
451d7de5bb
tde_create_translated_desktop: Incorporate a slightly modified version
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

Great, so we can have our custom tool across multiple platforms rather than rely on distro provided tools.

Great, so we can have our custom tool across multiple platforms rather than rely on distro provided tools.
MicheleC commented 3 years ago
Owner

we can also remove intltool from the dependencies in deb distros afterwards

we can also remove intltool from the dependencies in deb distros afterwards
SlavekB force-pushed feat/l10n-patched-intltool-merge from 451d7de5bb to 53c7e28984 3 years ago
SlavekB merged commit 53c7e28984 into master 3 years ago
SlavekB deleted branch feat/l10n-patched-intltool-merge 3 years ago
SlavekB added this to the R14.0.10 release milestone 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as 53c7e28984.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.10 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-cmake#67
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/l10n-patched-intltool-merge'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes