TDE
/
tde-cmake
6
0
Förgrening 0
Kod Ärenden Pull-förfrågningar Släpp Wiki Aktiviteter
Etiketter Milstenar

Implement tde_l10n_preparetips using the tde_l10n_prepare_xml #11

Sammanfogat
SlavekB sammanfogade 1 incheckningar från feat/replace-preparetips-by-prepare-xml in i master 5 år sedan
Konversation 0 Incheckningar 1 Ändrade Filer 1
SlavekB kommenterad 5 år sedan
Ägare

The tips files have an XML-like structure. The large portion of the tde_l10n_preparetips macro code was similar to the code in tde_l10n_prepare_xml. And since the tde_l10n_prepare_xml macro has many options (including remove leading empty lines), it could be used to prepare tips.

Note0: For this PR, it is required that #9 be already merged.

Note1: Tested with tips in tdebase: kate, ktip and konsole, and knowit application.

Note2: Here, it might make sense to mark translations as no-c-format, but the original prepartips script did not do this. That's why I kept it the same.

The `tips` files have an XML-like structure. The large portion of the tde_l10n_preparetips macro code was similar to the code in tde_l10n_prepare_xml. And since the tde_l10n_prepare_xml macro has many options (including remove leading empty lines), it could be used to prepare tips. Note0: For this PR, it is required that #9 be already merged. Note1: Tested with tips in tdebase: kate, ktip and konsole, and knowit application. Note2: Here, it might make sense to mark translations as `no-c-format`, but the original prepartips script did not do this. That's why I kept it the same.
MicheleC godkände dessa ändringar 5 år sedan
MicheleC lämnade en kommentar
Ägare

Looks ok

Looks ok
SlavekB closed this pull request 5 år sedan
SlavekB tog bort grenen feat/replace-preparetips-by-prepare-xml 5 år sedan
SlavekB lade till denna till milstolpe R14.0.6 release 5 år sedan
Pull-förfrågan har sammanfogats som 72ca5313ec.
Logga in för att delta i denna konversation.
Granskare
Begär granskning
Inga granskare
Etiketter
Tillämpa etiketter
Rensa etiketter
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Ingen Etikett GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milsten
Ange milstolpe
Rensa milstenar
Inga objekt
Ingen Milsten
R14.0.6 release
Tilldelade
Tilldela användare
Rensa tilldelade
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: TDE/tde-cmake#11
Skriv Förhandsgranska
Laddar…
Avbryt
Spara
Det finns inget innehåll än.
Ta bort branch 'feat/replace-preparetips-by-prepare-xml'

Borttagning utav en branch är permanent. Detta KAN INTE ångras. Vill du fortsätta?

Nej
Ja