Add common tde_setup_gcc_visibility macro #17

병합
SlavekB feat/add-test-gcc-visibility 에서 master 로 1 commits 를 머지했습니다 5 년 전
SlavekB 코멘트됨, 5 년 전
소유자

In many modules built with CMake, a GCC visibility test is performed. In most, a simple test is performed to determine if the system is a UNIX-type. In tdebase, there is a more in-depth test that checks if tdelibs are built with GCC visibility. The comment also states that it would be good to add a test to see if TQt is built with GCC visibility.

In order not to have all these tests in each module, I put all tests into a common cmake module as tde_setup_gcc_visibility macro. Thanks to this, it will now be simple in each module:

if( WITH_GCC_VISIBILITY )
   tde_setup_gcc_visibility( )
endif( )

The tests in tde_setup_gcc_visibility macro are prepared so that the TQt and tdelibs tests are performed only when they are installed / detected. This allows to use macro not only in the usual modules, but also in tdelibs, and in the future in TQt.

In many modules built with CMake, a GCC visibility test is performed. In most, a simple test is performed to determine if the system is a UNIX-type. In tdebase, there is a more in-depth test that checks if tdelibs are built with GCC visibility. The comment also states that it would be good to add a test to see if TQt is built with GCC visibility. In order not to have all these tests in each module, I put all tests into a common cmake module as `tde_setup_gcc_visibility` macro. Thanks to this, it will now be simple in each module: ``` if( WITH_GCC_VISIBILITY ) tde_setup_gcc_visibility( ) endif( ) ``` The tests in `tde_setup_gcc_visibility` macro are prepared so that the TQt and tdelibs tests are performed only when they are installed / detected. This allows to use macro not only in the usual modules, but also in tdelibs, and in the future in TQt.
SlavekB added the PR/rfc label 5 년 전
MicheleC 이 변경사항을 승인하였습니다. 5 년 전
MicheleC left a comment
소유자

LGTM

LGTM
MicheleC 코멘트됨, 5 년 전
소유자

before we push to cmake, let's try to build up to the base system with the modified macro.

before we push to cmake, let's try to build up to the base system with the modified macro.
SlavekB 코멘트됨, 5 년 전
포스터
소유자

I have successfully completed the tests of building tdebase and tdelibs 😸

I have successfully completed the tests of building tdebase and tdelibs :smile_cat:
MicheleC 코멘트됨, 5 년 전
소유자

Good enough then

Good enough then
SlavekB 코멘트됨, 5 년 전
포스터
소유자

Note: Because for TQt is unable to identify by definitions or header files whether the build was performed with GCC visibility, the test checks to see if the private class methods are visible in exported library symbols.

Note: Because for TQt is unable to identify by definitions or header files whether the build was performed with GCC visibility, the test checks to see if the private class methods are visible in exported library symbols.
SlavekB removed the PR/rfc label 5 년 전
SlavekB closed this pull request 5 년 전
SlavekB 삭제된 브랜치 feat/add-test-gcc-visibility 5 년 전
SlavekB R14.0.6 release 5 년 전 마일스톤을 추가하였습니다.
The pull request has been merged as b034c47597.
로그인하여 이 대화에 참여
No reviewers
마일스톤 없음
담당자 없음
참여자 2명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: TDE/tde-cmake#17
불러오는 중...
아직 콘텐츠가 없습니다.