Add common tde_setup_gcc_visibility macro #17

Scalone
SlavekB scala 1 commity/ów z feat/add-test-gcc-visibility do master 5 lat temu
SlavekB skomentował(-a) 5 lat temu
Właściciel

In many modules built with CMake, a GCC visibility test is performed. In most, a simple test is performed to determine if the system is a UNIX-type. In tdebase, there is a more in-depth test that checks if tdelibs are built with GCC visibility. The comment also states that it would be good to add a test to see if TQt is built with GCC visibility.

In order not to have all these tests in each module, I put all tests into a common cmake module as tde_setup_gcc_visibility macro. Thanks to this, it will now be simple in each module:

if( WITH_GCC_VISIBILITY )
   tde_setup_gcc_visibility( )
endif( )

The tests in tde_setup_gcc_visibility macro are prepared so that the TQt and tdelibs tests are performed only when they are installed / detected. This allows to use macro not only in the usual modules, but also in tdelibs, and in the future in TQt.

In many modules built with CMake, a GCC visibility test is performed. In most, a simple test is performed to determine if the system is a UNIX-type. In tdebase, there is a more in-depth test that checks if tdelibs are built with GCC visibility. The comment also states that it would be good to add a test to see if TQt is built with GCC visibility. In order not to have all these tests in each module, I put all tests into a common cmake module as `tde_setup_gcc_visibility` macro. Thanks to this, it will now be simple in each module: ``` if( WITH_GCC_VISIBILITY ) tde_setup_gcc_visibility( ) endif( ) ``` The tests in `tde_setup_gcc_visibility` macro are prepared so that the TQt and tdelibs tests are performed only when they are installed / detected. This allows to use macro not only in the usual modules, but also in tdelibs, and in the future in TQt.
SlavekB dodano PR/rfc etykietę 5 lat temu
MicheleC zatwierdza te zmiany 5 lat temu
MicheleC zostawił komentarz
Właściciel

LGTM

LGTM
MicheleC skomentował(-a) 5 lat temu
Właściciel

before we push to cmake, let's try to build up to the base system with the modified macro.

before we push to cmake, let's try to build up to the base system with the modified macro.
SlavekB skomentował(-a) 5 lat temu
Autor
Właściciel

I have successfully completed the tests of building tdebase and tdelibs 😸

I have successfully completed the tests of building tdebase and tdelibs :smile_cat:
MicheleC skomentował(-a) 5 lat temu
Właściciel

Good enough then

Good enough then
SlavekB skomentował(-a) 5 lat temu
Autor
Właściciel

Note: Because for TQt is unable to identify by definitions or header files whether the build was performed with GCC visibility, the test checks to see if the private class methods are visible in exported library symbols.

Note: Because for TQt is unable to identify by definitions or header files whether the build was performed with GCC visibility, the test checks to see if the private class methods are visible in exported library symbols.
SlavekB usunięto PR/rfc etykietę 5 lat temu
SlavekB zamknął(-ęła) ten pull request 5 lat temu
SlavekB usuwa gałąź feat/add-test-gcc-visibility 5 lat temu
SlavekB dodaje to do kamienia milowego R14.0.6 release 5 lat temu
Pull Request został scalony jako b034c47597.
Zaloguj się, aby dołączyć do tej rozmowy.
Brak recenzentów
Brak kamienia milowego
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: TDE/tde-cmake#17
Ładowanie…
Nie ma jeszcze treści.