Add common tde_setup_gcc_visibility macro #17

Слито
SlavekB слито 1 коммит(ов) из feat/add-test-gcc-visibility в master 5 лет назад
SlavekB прокомментировал(а) 5 лет назад
Владелец

In many modules built with CMake, a GCC visibility test is performed. In most, a simple test is performed to determine if the system is a UNIX-type. In tdebase, there is a more in-depth test that checks if tdelibs are built with GCC visibility. The comment also states that it would be good to add a test to see if TQt is built with GCC visibility.

In order not to have all these tests in each module, I put all tests into a common cmake module as tde_setup_gcc_visibility macro. Thanks to this, it will now be simple in each module:

if( WITH_GCC_VISIBILITY )
   tde_setup_gcc_visibility( )
endif( )

The tests in tde_setup_gcc_visibility macro are prepared so that the TQt and tdelibs tests are performed only when they are installed / detected. This allows to use macro not only in the usual modules, but also in tdelibs, and in the future in TQt.

In many modules built with CMake, a GCC visibility test is performed. In most, a simple test is performed to determine if the system is a UNIX-type. In tdebase, there is a more in-depth test that checks if tdelibs are built with GCC visibility. The comment also states that it would be good to add a test to see if TQt is built with GCC visibility. In order not to have all these tests in each module, I put all tests into a common cmake module as `tde_setup_gcc_visibility` macro. Thanks to this, it will now be simple in each module: ``` if( WITH_GCC_VISIBILITY ) tde_setup_gcc_visibility( ) endif( ) ``` The tests in `tde_setup_gcc_visibility` macro are prepared so that the TQt and tdelibs tests are performed only when they are installed / detected. This allows to use macro not only in the usual modules, but also in tdelibs, and in the future in TQt.
SlavekB добавлен PR/rfc с меткой 5 лет назад
MicheleC одобрил(а) эти изменения 5 лет назад
MicheleC оставил комментарий
Владелец

LGTM

LGTM
MicheleC прокомментировал(а) 5 лет назад
Владелец

before we push to cmake, let's try to build up to the base system with the modified macro.

before we push to cmake, let's try to build up to the base system with the modified macro.
SlavekB прокомментировал(а) 5 лет назад
Автор
Владелец

I have successfully completed the tests of building tdebase and tdelibs 😸

I have successfully completed the tests of building tdebase and tdelibs :smile_cat:
MicheleC прокомментировал(а) 5 лет назад
Владелец

Good enough then

Good enough then
SlavekB прокомментировал(а) 5 лет назад
Автор
Владелец

Note: Because for TQt is unable to identify by definitions or header files whether the build was performed with GCC visibility, the test checks to see if the private class methods are visible in exported library symbols.

Note: Because for TQt is unable to identify by definitions or header files whether the build was performed with GCC visibility, the test checks to see if the private class methods are visible in exported library symbols.
SlavekB удалён PR/rfc с меткой 5 лет назад
SlavekB закрыл этот запрос на слияние 5 лет назад
SlavekB удалил(а) ветку feat/add-test-gcc-visibility 5 лет назад
SlavekB добавил(а) к этапу R14.0.6 release 5 лет назад
Запрос на слияние был объединен как b034c47597.
Войдите, чтобы присоединиться к обсуждению.
Нет рецензентов
Нет этапа
Нет назначенных лиц
2 участников
Уведомления
Срок выполнения

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Reference: TDE/tde-cmake#17
Загрузка…
Пока нет содержимого.