#24 Avoid potential FTBFS in tde_setup_gcc_visibility

Merged
SlavekB merged 1 commits from feat/setup-gcc-visibility-kdemacros into master 2 months ago
SlavekB commented 2 months ago
  1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

  2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.
SlavekB added this to the R14.0.6 release milestone 2 months ago
MicheleC approved these changes 2 months ago
LGTM
SlavekB deleted branch feat/setup-gcc-visibility-kdemacros 2 months ago

Reviewers

MicheleC approved these changes 2 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.