Avoid potential FTBFS in tde_setup_gcc_visibility #24

Fusionado
SlavekB fusionados 1 commits de feat/setup-gcc-visibility-kdemacros en master hace 5 años
Propietario
  1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

  2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.
SlavekB ha añadido esto al hito R14.0.6 release hace 5 años
MicheleC aprobado estos cambios hace 5 años
MicheleC dejó un comentario
Propietario

LGTM

LGTM
SlavekB cerró este pull request hace 5 años
SlavekB rama eliminada feat/setup-gcc-visibility-kdemacros hace 5 años
El Pull Request se ha fusionado como f8254e1561.
Inicie sesión para unirse a esta conversación.
No hay revisores
Sin Milestone
No asignados
2 participantes
Notificaciones
Fecha de vencimiento

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: TDE/tde-cmake#24
Cargando…
Aún no existe contenido.