Avoid potential FTBFS in tde_setup_gcc_visibility #24

Unito
SlavekB ha unito 1 commit da feat/setup-gcc-visibility-kdemacros a master 5 anni fa
SlavekB 5 anni fa ha commentato
Proprietario
  1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

  2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.
SlavekB aggiunta alle pietre miliari R14.0.6 release 5 anni fa
MicheleC hanno approvato queste modifiche 5 anni fa
MicheleC lascia un commento
Proprietario

LGTM

LGTM
SlavekB chiusa questa pull request 5 anni fa
SlavekB branch feat/setup-gcc-visibility-kdemacros eliminato 5 anni fa
La pull request è stata unita come f8254e1561.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna milestone
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: TDE/tde-cmake#24
Caricamento…
Non ci sono ancora contenuti.