Avoid potential FTBFS in tde_setup_gcc_visibility #24

マージ済み
SlavekB が 1 個のコミットを feat/setup-gcc-visibility-kdemacros から master へマージ 5年前
SlavekB5年前 にコメント
オーナー
  1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

  2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.
SlavekB がマイルストーン R14.0.6 release に追加 5年前
MicheleC が変更を承認 5年前
MicheleC がコメント
オーナー

LGTM

LGTM
SlavekB がプルリクエストをクローズ 5年前
SlavekB がブランチ feat/setup-gcc-visibility-kdemacros を削除 5年前
プルリクエストは f8254e1561 でマージされています。
サインインしてこの会話に参加。
レビューアなし
マイルストーンなし
担当者なし
2 人の参加者
通知
期日

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: TDE/tde-cmake#24
読み込み中…
まだ内容がありません