Labels Mijlpalen

Avoid potential FTBFS in tde_setup_gcc_visibility #24

Samengevoegd

SlavekB heeft 1 commits samengevoegd van feat/setup-gcc-visibility-kdemacros naar master 5 jaren geleden

Discussie 0 Commits 1 Bestanden gewijzigd 1

SlavekB commented 5 jaren geleden

Eigenaar

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

SlavekB heeft dit 5 jaren geleden aan de mijlpaal R14.0.6 release toegevoegd

MicheleC heeft deze veranderingen 5 jaren geleden goedgekeurd

MicheleC heeft een reactie achtergelaten

Eigenaar

LGTM

LGTM

SlavekB heeft deze pull request gesloten 5 jaren geleden

SlavekB heeft 5 jaren geleden de branch feat/setup-gcc-visibility-kdemacros verwijderd.

De pull request is samengevoegd als f8254e1561.

Log in om deel te nemen aan deze discussie.

Reviewers

Beoordeling aanvragen

Geen beoordelaars

Labels

Labels toepassen

Verwijder labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

Geen label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Mijlpaal

Stel mijlpaal in

Verwijder mijlpaal

Geen items

Geen mijlpaal

R14.0.6 release

Toegewezen aan

Gebruikers toewijzen

Verwijder toegewezen aan

Niet toegewezen

2 deelnemers

Notificaties

Abonneren

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: TDE/tde-cmake#24

Schrijf Voorbeeld

Laden…

Annuleren

Opslaan

Er is nog geen inhoud.