TDE
/
tde-cmake
6
0
Forkuj 0
Kod Zgłoszenia Oczekujące zmiany Wydania Wiki Aktywność
Etykiety Kamienie milowe

Avoid potential FTBFS in tde_setup_gcc_visibility #24

Scalone
SlavekB scala 1 commity/ów z feat/setup-gcc-visibility-kdemacros do master 5 lat temu
Dyskusja 0 Commity 1 Zmodyfikowane pliki 1
SlavekB skomentował(-a) 5 lat temu
Właściciel

  1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

  2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.
SlavekB dodaje to do kamienia milowego R14.0.6 release 5 lat temu
MicheleC zatwierdza te zmiany 5 lat temu
MicheleC zostawił komentarz
Właściciel

LGTM

LGTM
SlavekB zamknął(-ęła) ten pull request 5 lat temu
SlavekB usuwa gałąź feat/setup-gcc-visibility-kdemacros 5 lat temu
Pull Request został scalony jako f8254e1561.
Zaloguj się, aby dołączyć do tej rozmowy.
Recenzenci
Poproś o recenzję
Brak recenzentów
Etykiety
Zastosuj etykiety
Wyczyść etykiety
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Brak etykiety GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Kamień milowy
Ustaw kamień milowy
Wyczyść kamień milowy
Brak elementów
Brak kamienia milowego
R14.0.6 release
Przypisani
Przypisz użytkowników
Usuń przypisanych
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: TDE/tde-cmake#24
Napisz Podgląd
Ładowanie…
Anuluj
Zapisz
Nie ma jeszcze treści.
Usuń gałąź 'feat/setup-gcc-visibility-kdemacros'

Usunięcie gałęzi jest trwałe i NIE MOŻE zostać cofnięte. Kontynuować?

Nie
Tak