6
0
Fork 0

Avoid potential FTBFS in tde_setup_gcc_visibility #24

Merge aplicado
SlavekB aplicou merge dos 1 commits de feat/setup-gcc-visibility-kdemacros em master 5 anos atrás
Proprietário
  1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

  2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.
SlavekB adicionou esta issue para o marco R14.0.6 release 5 anos atrás
MicheleC aprovou estas alterações 5 anos atrás
MicheleC deixou um comentário
Proprietário

LGTM

LGTM
SlavekB fechou este pull request 5 anos atrás
SlavekB excluiu branch feat/setup-gcc-visibility-kdemacros 5 anos atrás
O pull request teve merge aplicado como f8254e1561.
Acesse para participar desta conversação.
Sem revisor
Sem responsável
2 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: TDE/tde-cmake#24
Carregando…
Ainda não há conteúdo.