Avoid potential FTBFS in tde_setup_gcc_visibility #24

Merged
SlavekB merged 1 commits from feat/setup-gcc-visibility-kdemacros into master 5 years ago
Owner
  1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

  2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.
SlavekB added this to the R14.0.6 release milestone 5 years ago
MicheleC approved these changes 5 years ago
MicheleC left a comment
Owner

LGTM

LGTM
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/setup-gcc-visibility-kdemacros 5 years ago
The pull request has been merged as f8254e1561.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-cmake#24
Loading…
There is no content yet.