Etiketter Milstenar

Avoid potential FTBFS in tde_setup_gcc_visibility #24

Sammanfogat

SlavekB sammanfogade 1 incheckningar från feat/setup-gcc-visibility-kdemacros in i master 5 år sedan

Konversation 0 Incheckningar 1 Ändrade Filer 1

SlavekB kommenterad 5 år sedan

Ägare

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used.

2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

1. If a user builds in an environment that is not clean, while building dependencies that do not need tdelibs, the previously installed tdelibs can be searched for and gcc visibility tested. In that case, kdemacros.h that is not on CMAKE_INCLUDE_DIRS, can lead to a test failure. Therefore, the full path to the detected kdemacros.h is now used. 2. If a user builds in an environment that is not clean, and the module that is currently being built does not use TDE and / or TQt but these are found on the disk, they are tested on GCC visibility, which is unwanted and misleading. Therefore, tests are now conditioned by whether the module has already detected TDE and / or TQt.

SlavekB lade till denna till milstolpe R14.0.6 release 5 år sedan

MicheleC godkände dessa ändringar 5 år sedan

MicheleC lämnade en kommentar

Ägare

LGTM

LGTM

SlavekB closed this pull request 5 år sedan

SlavekB tog bort grenen feat/setup-gcc-visibility-kdemacros 5 år sedan

Pull-förfrågan har sammanfogats som f8254e1561.

Logga in för att delta i denna konversation.

Granskare

Begär granskning

Inga granskare

Etiketter

Tillämpa etiketter

Rensa etiketter

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

Ingen Etikett GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milsten

Ange milstolpe

Rensa milstenar

Inga objekt

Ingen Milsten

R14.0.6 release

Tilldelade

Tilldela användare

Rensa tilldelade

Ingen tilldelad

2 Deltagare

Notiser

Prenumerera

Förfallodatum

Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: TDE/tde-cmake#24

Skriv Förhandsgranska

Laddar…

Avbryt

Spara

Det finns inget innehåll än.