TDE
/
tde-cmake
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Use cache for TQt executables paths #29

Merged
SlavekB merged 1 commits from issue/28/cache-tqt-executables-paths into master 5 years ago
Conversation 2 Commits 1 Files Changed 1
SlavekB commented 5 years ago
Owner

Using CACHE without specifying FORCE will allow to pre-define paths for TQt executables. Typically, pre-defining paths is not needed, but it can be used to optimize cross compilation.

This will resolve issue #28.

Using `CACHE` without specifying `FORCE` will allow to pre-define paths for TQt executables. Typically, pre-defining paths is not needed, but it can be used to optimize cross compilation. This will resolve issue #28.
Fat-Zer commented 5 years ago
Collaborator

I would suggest to use "CACHE FILEPATH" rather than "CACHE INTERNAL", and then pass the variables to mark_as_advanced() if you want to exclude them from default ccmake/cmake-gui display.

I would suggest to use "`CACHE FILEPATH`" rather than "`CACHE INTERNAL`", and then pass the variables to [`mark_as_advanced()`](https://cmake.org/cmake/help/latest/command/mark_as_advanced.html) if you want to exclude them from default `ccmake`/`cmake-gui` display.
SlavekB commented 5 years ago
Poster
Owner

Thank you for reviewing. FILEPATH is clearly better. I have no experience with mark_as_advanced – I don't use ccmake or cmake-gui, but it seems like a good idea.

Patch updated.

Thank you for reviewing. `FILEPATH` is clearly better. I have no experience with `mark_as_advanced` – I don't use ccmake or cmake-gui, but it seems like a good idea. Patch updated.
SlavekB closed this pull request 5 years ago
SlavekB deleted branch issue/28/cache-tqt-executables-paths 5 years ago
SlavekB added this to the R14.0.7 release milestone 5 years ago
The pull request has been merged as 74654feb3b.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#28 Patch FindTQt.cmake to pre-define MOC_EXECUTABLE
TDE/tde-cmake
Reference: TDE/tde-cmake#29
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'issue/28/cache-tqt-executables-paths'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes