TDE
/
tde-cmake
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

tde_add_library: Add the ability to link libraries as private #53

Merged
SlavekB merged 1 commits from feat/library-link-private into master 4 years ago
Conversation 0 Commits 1 Files Changed 1
SlavekB commented 4 years ago
Owner

Currently, all shared linked libraries have been listed as interfaces and have therefore been published to the exported target. This could cause unnecessary linking, for example for the libr library in all other libraries and binaries.

After merging this patch, it will be possible to specify which libraries are to be exported as interfaces for the shared library and which are to be privately linked.

Currently, all shared linked libraries have been listed as *interfaces* and have therefore been published to the exported target. This could cause unnecessary linking, for example for the `libr` library in all other libraries and binaries. After merging this patch, it will be possible to specify which libraries are to be exported as interfaces for the shared library and which are to be privately linked.
MicheleC approved these changes 4 years ago
MicheleC left a comment
Owner

looks great!

looks great!
SlavekB closed this pull request 4 years ago
SlavekB deleted branch feat/library-link-private 4 years ago
SlavekB added this to the R14.0.9 release milestone 4 years ago
The pull request has been merged as d504c98bb7.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#88 Use private linking for exported CMake targets
TDE/tdelibs
Reference: TDE/tde-cmake#53
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/library-link-private'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes