TDE
/
tde-cmake
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Adjust CMakeL10n module to search for tde.pot in 'core/tdelibs' folder. #62

Merged
SlavekB merged 1 commits from fix/CMakeL10n-search-tde.pot-core-folder into master 3 years ago
Conversation 2 Commits 1 Files Changed 1
SlavekB commented 3 years ago
Owner

Moving the main modules to the new core folder requires modifying the search for tde.pot in the CMakeL10n module. I'm hesitant to do a search there only in the new path or whether to keep the search in the previous path without a core.

Because the CMakeL10n module has a specific use, it seems that it should be sufficient to search only in the core/tdelibs.

What is your opinion?

Moving the main modules to the new `core` folder requires modifying the search for `tde.pot` in the CMakeL10n module. I'm hesitant to do a search there only in the new path or whether to keep the search in the previous path without a `core`. Because the CMakeL10n module has a specific use, it seems that it should be sufficient to search only in the `core/tdelibs`. What is your opinion?
MicheleC commented 3 years ago
Owner

Looks good to me. We should search only in 'core' since there is no more tdelibs folder in 'main'

Looks good to me. We should search only in 'core' since there is no more tdelibs folder in 'main'
MicheleC approved these changes 3 years ago
SlavekB commented 3 years ago
Poster
Owner

As this is a change that is not critical for the moment, the merger may wait for a later time – for possible additional PR for common modules.

As this is a change that is not critical for the moment, the merger may wait for a later time – for possible additional PR for common modules.
👍 1
SlavekB added this to the R14.0.10 release milestone 3 years ago
SlavekB merged commit ae0ecf194b into master 3 years ago
SlavekB deleted branch fix/CMakeL10n-search-tde.pot-core-folder 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as ae0ecf194b.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.10 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-cmake#62
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/CMakeL10n-search-tde.pot-core-folder'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes