tde_create_translated_desktop: Prevent FTBFS on generated desktop files #69
Merged
SlavekB
merged 1 commits from fix/tde_create_translated_desktop
into master
3 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fix/tde_create_translated_desktop'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Fix FTBFS when translations are missing and the desktop file passed to
tde_create_translated_desktop() is build-time generated.
See TDE/tde-packaging-gentoo #196 for details.
Signed-off-by: Alexander Golubev fatzer2@gmail.com
That's good – using the CMake copy command for build time seems better than simply writing a file during configuration time. Only there it seems unnecessary to repeat the setting of the full path to
_src
.else( )
# just copy the original file without translations
get_filename_component( _src ${_src} ABSOLUTE )
Because you moved the full path settings to
_src
before all the variants, it seems unnecessary here as well.yep... missed this one... fixed & forced-pushed
95e409b6d2
tof0a5bcc760
3 years agoThank you, it looks good.
Note: It will wait a while for the merge before the current PR is tested and approved in the common admin module as well.
f0a5bcc760
into master 3 years agoReviewers
f0a5bcc760
.