tde_create_translated_desktop: Prevent FTBFS on generated desktop files #69

Merged
SlavekB merged 1 commits from fix/tde_create_translated_desktop into master 1 year ago
Fat-Zer commented 1 year ago
Collaborator

Fix FTBFS when translations are missing and the desktop file passed to
tde_create_translated_desktop() is build-time generated.

See TDE/tde-packaging-gentoo #196 for details.

Signed-off-by: Alexander Golubev fatzer2@gmail.com

Fix FTBFS when translations are missing and the desktop file passed to tde_create_translated_desktop() is build-time generated. See TDE/tde-packaging-gentoo #196 for details. Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
Fat-Zer added 1 commit 1 year ago
95e409b6d2 tde_create_translated_desktop: Prevent FTBFS on generated desktop files
SlavekB reviewed 1 year ago
SlavekB left a comment
Owner

That's good – using the CMake copy command for build time seems better than simply writing a file during configuration time. Only there it seems unnecessary to repeat the setting of the full path to _src.

That's good – using the CMake copy command for build time seems better than simply writing a file during configuration time. Only there it seems unnecessary to repeat the setting of the full path to `_src`.
else( )
# just copy the original file without translations
get_filename_component( _src ${_src} ABSOLUTE )
SlavekB commented 1 year ago
Owner

Because you moved the full path settings to _src before all the variants, it seems unnecessary here as well.

Because you moved the full path settings to `_src` before all the variants, it seems unnecessary here as well.
Fat-Zer commented 1 year ago
Poster
Collaborator

yep... missed this one... fixed & forced-pushed

yep... missed this one... fixed & forced-pushed
SlavekB marked this conversation as resolved
Fat-Zer force-pushed fix/tde_create_translated_desktop from 95e409b6d2 to f0a5bcc760 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

Thank you, it looks good.

Note: It will wait a while for the merge before the current PR is tested and approved in the common admin module as well.

Thank you, it looks good. Note: It will wait a while for the merge before the current PR is tested and approved in the common admin module as well.
SlavekB merged commit f0a5bcc760 into master 1 year ago
SlavekB deleted branch fix/tde_create_translated_desktop 1 year ago
SlavekB added this to the R14.0.10 release milestone 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as f0a5bcc760.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.