TDE
/
tde-common-cmake
6
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity
Labels Milestones

CMakeL10n: Prevent exclusion _translatorinfo when using X-POT #78

Merged
SlavekB merged 1 commits from feat/CMakeL10n-protect-translatorinfo-over-X-POT into master 11 months ago
Conversation 0 Commits 1 Files Changed 1
SlavekB commented 11 months ago
Owner

Here are cases when it would be good next to the standard tde.pot to use a second template for X-POT. In particular, twin styles, which usually use the twin_clients catalog. The use of X-POT, which contains _translatorinfo causes these to be excluded from the generated POT file, which is not desirable.

Patch in this PR changes that _translatorinfo are processed separately so that they cannot be excluded by X-POT.

Here are cases when it would be good next to the standard `tde.pot` to use a second template for X-POT. In particular, twin styles, which usually use the `twin_clients` catalog. The use of X-POT, which contains `_translatorinfo` causes these to be excluded from the generated POT file, which is not desirable. Patch in this PR changes that `_translatorinfo` are processed separately so that they cannot be excluded by X-POT.
SlavekB added 1 commit 11 months ago
e20e437035
CMakeL10n: Prevent exclusion _translatorinfo when using X-POT.
SlavekB force-pushed feat/CMakeL10n-protect-translatorinfo-over-X-POT from e20e437035 to 6e5de8d66e 11 months ago
MicheleC approved these changes 11 months ago
MicheleC left a comment
Owner

Looks good

Looks good
SlavekB force-pushed feat/CMakeL10n-protect-translatorinfo-over-X-POT from 6e5de8d66e to fa09639dea 11 months ago
SlavekB merged commit fa09639dea into master 11 months ago
SlavekB deleted branch feat/CMakeL10n-protect-translatorinfo-over-X-POT 11 months ago
SlavekB added this to the R14.0.11 release milestone 11 months ago

Reviewers

MicheleC approved these changes 11 months ago
The pull request has been merged as fa09639dea.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#2 Exclude common strings of twin clients from translations
TDE/twin-style-crystal
#5 Exclude common strings of twin clients from translations
TDE/twin-style-suse2
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/CMakeL10n-protect-translatorinfo-over-X-POT'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes