Add "Magyar" string #38

Closed
lhaecker wants to merge 1 commits from lhaecker/tde-i18n:master into master
Collaborator
There is no content yet.
lhaecker added 1 commit 2 years ago
lhaecker closed this pull request 2 years ago
lhaecker reopened this pull request 2 years ago
Owner

Welcome to the TDE project! If you want to contribute with code, we will add you to the Contributors team so that you can use the shared collaboration with branches model, which we prefer over forking – see TGW wiki page.

Regarding your current PR, TDE Weblate (TWTW) is also used to translate strings in entry.desktop files – see tdelibs/i18n-entrydesktop-files. Therefore, instead of a pull request, you can check and update strings using TWTW. The translations from TWTW will then automatically become part of the source tree and are included in the desktop files during the build of the binary packages. This is why desktop files are completely untranslated in the source tree. See po files with translations for desktop files.

Welcome to the TDE project! If you want to contribute with code, we will add you to the [Contributors team](../../org/TDE/teams/contributors) so that you can use the shared collaboration with branches model, which we prefer over forking – see [TGW wiki page](https://wiki.trinitydesktop.org/TDE_Gitea_Workspace). Regarding your current PR, TDE Weblate (TWTW) is also used to translate strings in `entry.desktop` files – see [tdelibs/i18n-entrydesktop-files](https://mirror.git.trinitydesktop.org/weblate/projects/tdelibs/i18n-entrydesktop-files/). Therefore, instead of a pull request, you can check and update strings using TWTW. The translations from TWTW will then automatically become part of the source tree and are included in the desktop files during the build of the binary packages. This is why desktop files are completely untranslated in the source tree. See [`po` files](src/branch/master/translations/desktop_files/entry.desktop) with translations for desktop files.
Owner

@lhaecker
Welcome to the TDE project, Laslo. As Slavek explained, TWTW is the best and fastst place to add translations. And TWTW credits your work with your name as well.

@SlavekB
should we merge this PR or close it for the aforementioned reasons and let @lhaecker do it on TWTW?

@lhaecker Welcome to the TDE project, Laslo. As Slavek explained, TWTW is the best and fastst place to add translations. And TWTW credits your work with your name as well. @SlavekB should we merge this PR or close it for the aforementioned reasons and let @lhaecker do it on TWTW?
Owner

@SlavekB
should we merge this PR or close it for the aforementioned reasons and let @lhaecker do it on TWTW?

This is definitely not suitable for merging. As I mentioned above, desktop files in the source tree must be without translations, because translations are included into desktop files from the po files during build.

> @SlavekB > should we merge this PR or close it for the aforementioned reasons and let @lhaecker do it on TWTW? This is definitely not suitable for merging. As I mentioned above, desktop files in the source tree must be without translations, because translations are included into desktop files from the `po` files during build.
Owner

Perfect, tbh I had not looked at the changes :-)
I suggest we close this and @lhaecker can submit the change in TWTW

Perfect, tbh I had not looked at the changes :-) I suggest we close this and @lhaecker can submit the change in [TWTW](https://wiki.trinitydesktop.org/TDE_Weblate_Translation_Workspace)
SlavekB closed this pull request 2 years ago
SlavekB added the ST/invalid label 2 years ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-i18n#38
Loading…
There is no content yet.