Live ebuilds: Port to EAPI7 and cleanup - Round 3. #13
Merged
Chris
merged 1 commits from feat/EAPI7-live-round3
into master
4 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/EAPI7-live-round3'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Worked and build for me like a charm. With that PR, at least the whole tdebase-meta EAPI7 port is done for the live ebuilds.
Notice the -DWITH_SUDO_TDESU_BACKEND, which was wrong before, if you port that to the stable ebuilds. I also re-used your einfo text for that sudo flag.
The glib dependency was needed, because otherwise nsplugins fails to build. Something different than glib2 isn't in Portage anymore, so just depending on glib is fine.
The starttde patch is broken and at quick look it seems that was adopted in TDE upstream anyway. Haven't looked deeper into that.
Blocking of old KDE3 or TDE 3.5.x ebuilds isn't needed anymore.
Also dependencies on specific (old) versions removed. Should be okay that way and worked for me, but maybe you have some suggestions? Let me know. 👍
Signed-off-by: Chris xchrisx@uber.space
I'll correct the -DWITH_SUDO_TDESU_BACKEND in tdesu in the stable builds when I get that far, provided it passes a sanity check against CMakeLists. I don't see any issue with the rest (the only dependency version I've seen in any ebuild so far that makes me at all concerned is the one for openssl in tdelibs). And I'm not surprised that the starttde patch is broken—I remember it giving me trouble when I installed TDE to this computer a couple of years ago.
(Sorry for being a bit behind on replies. I'm back at work this week, which is eating into the time and energy I have for this.)
Only a little comment from me…
src_compile() {
# Patch the starttde script to setup the environment for KDE 4.0
# Patch the starttde script to setup the environment for TDE
I think that the replacements performed here have no effect, because the current starttde script contains no
@REPLACE_PREFIX@
or@REPLACE_LIBS@
. So there is no work forsed
.Interesting. So far I haven't looked at that. But glad you did. Most likely that is from some very old KDE 4.0 ebuild. So I will remove that too. Thanks for looking.
@eliddell: No problem. Just take your time. I just don't want to sabotage your work. So if you want to not touch some parts, just let me know.
That review will not be the last one. I concentrate just to get ride of the old eclasses, so we can move on. 😸
13f3b6432f
.