Add trinity-admin-prepare, trinity-gen-configure and trinity-econf functions
#165
Merged
SlavekB
merged 1 commits from feat/econf-gen-func
into master
4 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/econf-gen-func'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Signed-off-by: ormorph roma251078@mail.ru
These functions are required to build packages using the
admin
module and theconfigure
script. These features are planned to be used in packages such as tdewebdev, which do not use the cmake utility for assembly.It is also planned to use these functions in combination with eclass
trinity-meta-2
, with the addition of the following lines to the ebuild file:WIP: Add `trinity-admin-prepare, trinity-gen-configure and trinity-econf functions`to Add `trinity-admin-prepare, trinity-gen-configure and trinity-econf functions` 4 years agoGreat, @ormorph! 👍
Original I had the idea to introduce some
TRINITY_BS
in the ebuilds and just add some ifs and elses in the ebuilds code, where the default value would beCMAKE
. But I think this way it will work too.At the moment working on TDE for me is really hard, because I rarely can access TGW, because of DNS problems.
Maybe your idea is the better one, because I expect that in next time
tdewebdev
andtdeaccessibility
will be ported to CMake. At least it is already in work.About the to be extracted files - Maybe it would make sense to integrate them in the eclasses directly (like it is done for the CMakeLists)? Let me know, if it can be merged.
Today the
|| die
safeguards for Portage built in commands likeemake
with modern EAPIs aren't needed anymore.For example, create a function:
Next, call the function in the ebuild:
The next way is to add a variable to
trinity-base-2
:then add to ebild:
Ok I understood.
I don’t think it’s worth combining this with existing code in eclass, as there is a gradual transition to cmake. Otherwise, there may be more problems associated with the removal of already non-working code from eclass. I think complicating the code will be superfluous. Therefore, I decided to add only those functions that can be called in the ebuild file, which can be combined with the already created functionality.
I decided to create a test branch
trinity-nomodule
, for downloading from alternative sources. I integrated these functions into eclass, achieved compatibility with the assembly using theadmin
module. Compatibility is provided by thecheck_admin
function. TheADMIN_LIST
variable in the inside of the function is responsible for this. Addedtdewebdev-meta
packages. I tested the working ability on version 14.0.8.Add `trinity-admin-prepare, trinity-gen-configure and trinity-econf functions`to WIP:Add `trinity-admin-prepare, trinity-gen-configure and trinity-econf functions` 4 years agoI did a rebase on the current HEAD. There was no need to resolve any significant conflicts.
Are there any reasons why PR is labeled as WIP? Or is it possible to move forward and merge it?
In principle, you can merge. I will make corrections and additions in the new PR later.
You can also merge #162.
This one's a bit beyond my ability to evaluate for functionality, but it doesn't seem likely to break anything. I'm okay with merging it.
WIP:Add `trinity-admin-prepare, trinity-gen-configure and trinity-econf functions`to Add `trinity-admin-prepare, trinity-gen-configure and trinity-econf functions` 4 years agod531cb5908
into master 4 years agod531cb5908
.