trinity-base/libksieve-14.0.8 depends on trinity-base/libtdepim #192

Closed
opened 3 years ago by efferre · 6 comments
Collaborator

Basic information

  • TDE version: R14.0.8
  • Distribution: Gentoo
  • Hardware: amd64

Description

I am trying to install kmail from the TDE official gentoo overlay. I have unmasked only the needed packages. This is the first install of TDE libs/applications.

Steps to reproduce

$ emerge trinity-base/kmail

The building fails on libksieve but it continues as mush as it can. At the end, besides kmail installation, the only missing dependency is libksieve. During emerge run trinity-base/libtdepim has been regularly installed after the failure here described.
Here it is attached the log with the error.

Adding a DEPEND line towards trinity-base/libtdepim in trinity-base/libksieve should be fine to solve the issue

## Basic information - TDE version: R14.0.8 - Distribution: Gentoo - Hardware: amd64 ## Description I am trying to install kmail from the TDE official gentoo overlay. I have unmasked only the needed packages. This is the first install of TDE libs/applications. ## Steps to reproduce $ emerge trinity-base/kmail The building fails on libksieve but it continues as mush as it can. At the end, besides kmail installation, the only missing dependency is libksieve. During emerge run trinity-base/libtdepim has been regularly installed after the failure here described. Here it is attached the log with the error. Adding a DEPEND line towards trinity-base/libtdepim in trinity-base/libksieve should be fine to solve the issue
Owner

At first glance, it seems to me that #include <tdepimmacros.h> can be safely replaced by #include <kdemacros.h>, thus eliminating the need for libtdepim dependency for libksieve.

At first glance, it seems to me that `#include <tdepimmacros.h>` can be safely replaced by `#include <kdemacros.h>`, thus eliminating the need for `libtdepim` dependency for `libksieve`.
Poster
Collaborator

I confirm that your suggestion solves the problem, here is the patch I have applied to version 14.0.8:

--- ./libksieve/ksieve/error.h.old  2020-04-11 01:08:32.000000000 +0200
+++ ./libksieve/ksieve/error.h  2021-02-25 17:02:08.787909752 +0100
@@ -35,7 +35,7 @@

 #include <tqstring.h>

-#include <tdepimmacros.h>
+#include <kdemacros.h>

 #ifdef None // X headers
 #  undef None
--- ./libksieve/ksieve/parser.h.old 2020-04-11 01:08:32.000000000 +0200
+++ ./libksieve/ksieve/parser.h 2021-02-25 17:02:08.786909752 +0100
@@ -33,7 +33,7 @@
 #ifndef __KSIEVE_PARSING_H__
 #define __KSIEVE_PARSING_H__

-#include <tdepimmacros.h>
+#include <kdemacros.h>

 class TQString;

I confirm that your suggestion solves the problem, here is the patch I have applied to version 14.0.8: ``` --- ./libksieve/ksieve/error.h.old 2020-04-11 01:08:32.000000000 +0200 +++ ./libksieve/ksieve/error.h 2021-02-25 17:02:08.787909752 +0100 @@ -35,7 +35,7 @@ #include <tqstring.h> -#include <tdepimmacros.h> +#include <kdemacros.h> #ifdef None // X headers # undef None --- ./libksieve/ksieve/parser.h.old 2020-04-11 01:08:32.000000000 +0200 +++ ./libksieve/ksieve/parser.h 2021-02-25 17:02:08.786909752 +0100 @@ -33,7 +33,7 @@ #ifndef __KSIEVE_PARSING_H__ #define __KSIEVE_PARSING_H__ -#include <tdepimmacros.h> +#include <kdemacros.h> class TQString; ```
Owner

Great, thank you for your confirmation. I assume that such a replacement will be possible in the whole tdepim and then remove tdepimmacros.h.

Great, thank you for your confirmation. I assume that such a replacement will be possible in the whole tdepim and then remove `tdepimmacros.h`.
Owner

Replacement of tdepimmacros.h made within TDE/tdepim#50, which will be part of R14.0.10. Unfortunately, I don't know what a good way to temporarily use such an adjustment for older versions that are built here.

Replacement of `tdepimmacros.h` made within TDE/tdepim#50, which will be part of R14.0.10. Unfortunately, I don't know what a good way to temporarily use such an adjustment for older versions that are built here.
Collaborator

Ebuilds can apply patches to the code they build. I'll try to get it done this weekend.

Ebuilds can apply patches to the code they build. I'll try to get it done this weekend.
Collaborator

The simplest way would be to extract libtdepim dir as well...

The simplest way would be to extract libtdepim dir as well...
Fat-Zer referenced this issue from a commit 3 years ago
SlavekB closed this issue 3 years ago
SlavekB referenced this issue from a commit 3 years ago
SlavekB added this to the R14.0.10 release milestone 3 years ago
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#192
Loading…
There is no content yet.