kweather build issue #196

Basic information

TDE version: R14.1.0 [DEVELOPMENT]
Distribution: Gentoo
Hardware: amd64

Description

compilation error:
CMake Error at cmake/modules/TDEMacros.cmake:2048 (file):
  file failed to open for reading (No such file or directory):

    /var/tmp/portage/trinity-base/kweather-9999/work/kweather-9999_build/kweather/weather_stations.desktop
Call Stack (most recent call first):
  kweather/CMakeLists.txt:136 (tde_create_translated_desktop)

looks like file kweather_stations.desktop is missing, it is nowhere in the build directory.

Steps to reproduce

emerge -av trinity-base/kweather

Screenshots

CMakeOutput.log

49 KiB

build.log

9.7 KiB

I've already looked into this one a bit, it's caused by combination of two issues:

The fact that eclasses doesn't extract the translations, see #195
An issue with tde_create_translated_desktop () in TDEMacros.cmake, which fails if translations are missing and the desktop file is build-time generated, see TDE/tde-common-cmake#69.

We probably should resolve both of those.

Since the merge of TDE/tde-common-cmake#69 the live one version should build fine. Although I haven't actually tested this myself...

I suggest to keep this issue open till the resolution of the problem with desktop file translations.

Also I haven't looked if the stable one was affected (it probably should be), but it should go after the fix of the translation issue too.

The stable version does not seem to need any specific patch. Desktop file generation has been added for the upcoming R14.0.10, which also already includes a fix in the common cmake module.

Thank you guys!