For some parts of the tdebase, the WITH_TDEHWLIB build option is missing #210
Merged
SlavekB
merged 1 commits from fix/tdebase-add-missing-with-tdehwlib-option
into master
3 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fix/tdebase-add-missing-with-tdehwlib-option'
Deleting a branch is permanent. It CANNOT be undone. Continue?
This can lead to FTBFS.
Please test it.
Won't work as presented. You need to add hwlib to IUSE (which is a space-separated list of tags). use.local.desc in profiles also needs to be amended, or hwlib needs to be moved into use.desc .
Also, there is a longstanding request to make everything compile correctly without the hardware lib. Did this get lost in the shuffle somehow?
0827a9080a
to350ec7b040
3 years agoTag hwlib added to IUSE. For
use.local.desc
, respectively,use.desc
I do not know whether I understand the request because hwlib is already listed inuse.desc
.You can notice that on the master branch there have been a few fixes relating to build without tdehw library. On stable branch there building without tdehw library should work because building on FreeBSD is done just without tdehw library.
I checked against a local copy of use.desc, so it was probably out of date. Sorry.
In BSD, I believe HAL replaces the tdehw library. It's possible that current stable builds correctly without either backend—tdelibs-14.0.8 did not.
(I'm aware I really need to get the stable ebuilds up to date. Stress++ = Productivity-- ).
Assembly is not possible yet due to missing library
-ltdehw-shared
. For now, I propose to mark this PR as wip:.Did you make an emerge for current tdelibs on master branch? Because the tdehw library was only recently separated into a standalone file.
No, I haven't done it yet, I'll rebuild branch 9999 later and check it out. But in any case, it will not be compiled yet, since the name of the installed library is different. The name must not contain the word
shared
.No, the name is as it should be. Once the current tdelibs will be built, then the CMake target will be defined, whose name is
tdehwlib-shared
. Linking uses the exported name of CMake target, thereforetdehwlib-shared
is quite fine.Deleted build 9999 and put it back together. Everything worked out. The difficulty with the 9999 branch is that it needs to be rebuilt from time to time.
I think this PR can be merge.
350ec7b040
into master 3 years agoReviewers
350ec7b040
.