Added custom patch for musl, hwlib support #282

Merged
SlavekB merged 1 commits from feat/muslhwlib into master 1 year ago
ormorph commented 1 year ago
Collaborator

Added a fix for musl, support for the health of the hwlib assembly.
The getnameinfo() function in musl behaves differently from glibc.If the structure pointer is zero, then the function ends with a segmentation fault.

Added a fix for musl, support for the health of the hwlib assembly. The `getnameinfo()` function in musl behaves differently from glibc.If the structure pointer is zero, then the function ends with a segmentation fault.
ormorph commented 1 year ago
Poster
Collaborator

At the moment, musl is still poorly supported, for example, when trying to type in KUrlComboBox, the whole widget stops responding, it seems to happen when searching for files while typing, but this is not yet certain.

At the moment, musl is still poorly supported, for example, when trying to type in KUrlComboBox, the whole widget stops responding, it seems to happen when searching for files while typing, but this is not yet certain.
SlavekB commented 1 year ago
Owner

Potential dereference of zero pointer seems to be a good idea for all cases – regardless of the internal implementation of getnameinfo(). Therefore, I think you can promote it for the main tdelibs.

Potential dereference of zero pointer seems to be a good idea for all cases – regardless of the internal implementation of `getnameinfo()`. Therefore, I think you can promote it for the main tdelibs.
ormorph commented 1 year ago
Poster
Collaborator

Hmm, ok I'll add this patch to the stable branch and add a request for tdelibs-14.1.x. Either way, it works. There were no problems with other pointers, so it is only used here for ifa->ifa_ifu.ifu_broadaddr and ifa->ifa_ifu.ifu_dstaddr. Now I will change this PR.

Hmm, ok I'll add this patch to the stable branch and add a request for tdelibs-14.1.x. Either way, it works. There were no problems with other pointers, so it is only used here for `ifa->ifa_ifu.ifu_broadaddr` and `ifa->ifa_ifu.ifu_dstaddr`. Now I will change this PR.
ormorph force-pushed feat/muslhwlib from b0ff8ab84f to df82ccb902 1 year ago
ormorph commented 1 year ago
Poster
Collaborator

Ok, now the PR has been changed. Now it remains to add this to the tdelibs project.

Ok, now the PR has been changed. Now it remains to add this to the tdelibs project.
ormorph commented 1 year ago
Poster
Collaborator

Hmm, I still need to fix the commit name.

Hmm, I still need to fix the commit name.
ormorph force-pushed feat/muslhwlib from df82ccb902 to 6d45d1a320 1 year ago
ormorph force-pushed feat/muslhwlib from 6d45d1a320 to 777210eb8a 1 year ago
ormorph commented 1 year ago
Poster
Collaborator

Now it looks normal.

Now it looks normal.
SlavekB commented 1 year ago
Owner

You seem to have pushed the commit into a branch for TDE/tdelibs, but you forgot to create a PR 😉

You seem to have pushed the commit into a branch for TDE/tdelibs, but you forgot to create a PR 😉
SlavekB commented 1 year ago
Owner

You seem to have pushed the commit into a branch for TDE/tdelibs, but you forgot to create a PR 😉

Apology – it's out of date – you created PR in parallel with my comment 👍

> You seem to have pushed the commit into a branch for TDE/tdelibs, but you forgot to create a PR 😉 Apology – it's out of date – you created PR in parallel with my comment 👍
ormorph commented 1 year ago
Poster
Collaborator

Apology – it's out of date – you created PR in parallel with my comment 👍

Yes. I needed to check the build first before creating the PR :

# EGIT_OVERRIDE_BRANCH_GITEA_TDE_TDELIBS="feat/hwlib" emerge -1 tdelibs
> Apology – it's out of date – you created PR in parallel with my comment 👍 Yes. I needed to check the build first before creating the PR : ``` # EGIT_OVERRIDE_BRANCH_GITEA_TDE_TDELIBS="feat/hwlib" emerge -1 tdelibs ```
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

Ok, it makes sense that it is added for the stable branch as an additional commit.

Ok, it makes sense that it is added for the stable branch as an additional commit.
SlavekB merged commit 777210eb8a into master 1 year ago
SlavekB deleted branch feat/muslhwlib 1 year ago
SlavekB added this to the R14.1.0 release milestone 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as 777210eb8a.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#282
Loading…
There is no content yet.