Added custom patch for musl, hwlib support #282
Merged
SlavekB
merged 1 commits from feat/muslhwlib
into master
1 year ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/muslhwlib'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Added a fix for musl, support for the health of the hwlib assembly.
The
getnameinfo()
function in musl behaves differently from glibc.If the structure pointer is zero, then the function ends with a segmentation fault.At the moment, musl is still poorly supported, for example, when trying to type in KUrlComboBox, the whole widget stops responding, it seems to happen when searching for files while typing, but this is not yet certain.
Potential dereference of zero pointer seems to be a good idea for all cases – regardless of the internal implementation of
getnameinfo()
. Therefore, I think you can promote it for the main tdelibs.Hmm, ok I'll add this patch to the stable branch and add a request for tdelibs-14.1.x. Either way, it works. There were no problems with other pointers, so it is only used here for
ifa->ifa_ifu.ifu_broadaddr
andifa->ifa_ifu.ifu_dstaddr
. Now I will change this PR.b0ff8ab84f
todf82ccb902
1 year agoOk, now the PR has been changed. Now it remains to add this to the tdelibs project.
Hmm, I still need to fix the commit name.
df82ccb902
to6d45d1a320
1 year ago6d45d1a320
to777210eb8a
1 year agoNow it looks normal.
You seem to have pushed the commit into a branch for TDE/tdelibs, but you forgot to create a PR 😉
Apology – it's out of date – you created PR in parallel with my comment 👍
Yes. I needed to check the build first before creating the PR :
Ok, it makes sense that it is added for the stable branch as an additional commit.
777210eb8a
into master 1 year agoReviewers
777210eb8a
.