Desktop file validation check fails for a lot of ebuilds. #30

Open
opened 4 years ago by Chris · 2 comments
Chris commented 4 years ago
Collaborator

Because Gentoo is offering some, in this case, useful QA checks for desktop files installed by ebuilds, I noticed that a lot of TDE related desktop files fail this validation. Which is resulting in messages like:

QA Notice: This package installs one or more .desktop files that do not pass validation.

 /usr/trinity/14/share/applications/tde/tdepowersave.desktop: error: value item "Applet" in key "Categories" in group "Desktop Entry" is a reserved category, so a "OnlyShowIn" key must be included

That could be some good way to fix this desktop files upstream, which is the right way. For some files I even got some message they violate some check so bad, that in future that will end in some fatal error.

I am not sure what package it was I got the last message from.

Because Gentoo is *offering* some, in this case, useful QA checks for desktop files installed by ebuilds, I noticed that a lot of TDE related desktop files fail this validation. Which is resulting in messages like: > QA Notice: This package installs one or more .desktop files that do not pass validation. > > /usr/trinity/14/share/applications/tde/tdepowersave.desktop: error: value item "Applet" in key "Categories" in group "Desktop Entry" is a reserved category, so a "OnlyShowIn" key must be included That could be some good way to fix this desktop files upstream, which is the right way. For some files I even got some message they violate some check so bad, that in future that will end in some fatal error. I am not sure what package it was I got the last message from.
Collaborator

The validation is performed by desktop-file-validate, which is opendesktop.org's baby. From what I can tell, the specific error you got can be fixed by adding "OnlyShowIn=TDE;" to the .desktop file right after the "Categories" line. (Fortunately, someone took the time to register TDE with them, so it should be recognized in recent-enough versions of the tool.)

References, if you need them:

https://wiki.gentoo.org/wiki/.desktop_files

https://specifications.freedesktop.org/desktop-entry-spec/latest/

https://specifications.freedesktop.org/menu-spec/latest/

The validation is performed by desktop-file-validate, which is opendesktop.org's baby. From what I can tell, the specific error you got can be fixed by adding "OnlyShowIn=TDE;" to the .desktop file right after the "Categories" line. (Fortunately, someone took the time to register TDE with them, so it should be recognized in recent-enough versions of the tool.) References, if you need them: https://wiki.gentoo.org/wiki/.desktop_files https://specifications.freedesktop.org/desktop-entry-spec/latest/ https://specifications.freedesktop.org/menu-spec/latest/
Chris commented 4 years ago
Poster
Collaborator

Thanks for your input about that!

Yes, no worries, I know about how to fix that already and it was not meant to blame or search some ways to get ride of it. That XDG already added TDE I have read about last time I worked on some desktop files in TDE myself and that made me very happy to see that was included. 😸

I am trying just to note down here as much as possible, so it never get lost. Also, if some users experience about that messages, they should see it is known and maybe they want to fix it? Maybe I will do it myself ebuild by ebuild later and use that issue here as some kind of notepad for listing what component is fixed already.

Thanks for your input about that! Yes, no worries, I know about how to fix that already and it was not meant to blame or search some ways to get ride of it. That XDG already added *TDE* I have read about last time I worked on some desktop files in TDE myself and that made me very happy to see that was included. :smile_cat: I am trying just to note down here as much as possible, so it never get lost. Also, if some users experience about that messages, they should see it is known and maybe they want to fix it? Maybe I will do it myself ebuild by ebuild later and use that issue here as some kind of notepad for listing what component is fixed already.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#30
Loading…
There is no content yet.