FEATURES="installsources" doesn't work on tde packages #331

Open
opened 5 months ago by Fat-Zer · 7 comments
Collaborator

Description

Somewhy FEATURES="installsources" doesn't work when emerging trinity packages from the overlay. I have no clue why.

Steps to reproduce

  1. emerge dev-util/debugedit
  2. FEATURES="installsources" CFLAGS="-ggdb -O0" CXXFLAGS="-ggdb -O0" emerge trinity-base/kdialog
  3. there should be kdialog sources install in /usr/src/debug/trinity-base/kdialog but there are none.

The same thing is true for all the ebuilds based on tde's cmake.

## Description Somewhy FEATURES="installsources" doesn't work when emerging trinity packages from the overlay. I have no clue why. ## Steps to reproduce 1. `emerge dev-util/debugedit` 2. `FEATURES="installsources" CFLAGS="-ggdb -O0" CXXFLAGS="-ggdb -O0" emerge trinity-base/kdialog` 3. there should be kdialog sources install in /usr/src/debug/trinity-base/kdialog but there are none. The same thing is true for all the ebuilds based on tde's cmake.
Collaborator

Well, yes, there is such a thing, only tqt works normally, but what doesn’t work in cmake. Only the one that uses the admin module works.
In this case, I simply debugged in the source code directory, and the breakpoint worked.

Well, yes, there is such a thing, only tqt works normally, but what doesn’t work in cmake. Only the one that uses the admin module works. In this case, I simply debugged in the source code directory, and the breakpoint worked.
Poster
Collaborator

@ormorph do you have any idea why this might happen?

@ormorph do you have any idea why this might happen?
Collaborator

If I had ideas, I would have changed something already. To do this, you need to know at least how this mechanism works.

If I had ideas, I would have changed something already. To do this, you need to know at least how this mechanism works.
Poster
Collaborator

Found the violators: it's -fdebug-prefix-map and -fmacro-prefix-map in TDEMacros.

Remove those and the sources start to get installed fine... don't know how to fix it in orderly manner yet...

Found the violators: it's `-fdebug-prefix-map` and `-fmacro-prefix-map` in [TDEMacros][1]. Remove those and the sources start to get installed fine... don't know how to fix it in orderly manner yet... [1]: https://mirror.git.trinitydesktop.org/gitea/TDE/tde-cmake/src/commit/ea17fae58d4adb828dbead3e87dda9c604e2c8d5/modules/TDEMacros.cmake#L2897
Collaborator

Remove those and the sources start to get installed fine... don't know how to fix it in orderly manner yet...

Some may find this useful. For Gentoo, relative paths are not generally needed. You can simply remove these lines if you build the trinity-cmake package with the debug flag. True, then you will need to add information about this to the documentation.
This can all be solved using Gentoo tools.

sed -e '/-fdebug-prefix-map/d' -e '/-fmacro-prefix-map/d' -i "${S}/modules/TDEMacros.cmake" || die

It would most likely be wrong to remove it from tde-cmake, but it can be done using build tools.

> Remove those and the sources start to get installed fine... don't know how to fix it in orderly manner yet... Some may find this useful. For Gentoo, relative paths are not generally needed. You can simply remove these lines if you build the `trinity-cmake` package with the `debug` flag. True, then you will need to add information about this to the documentation. This can all be solved using Gentoo tools. ``` sed -e '/-fdebug-prefix-map/d' -e '/-fmacro-prefix-map/d' -i "${S}/modules/TDEMacros.cmake" || die ``` It would most likely be wrong to remove it from tde-cmake, but it can be done using build tools.
Poster
Collaborator

I lean towards patching tde-cmake to make them conditional and then disable them either during gentoo build or at least when FEATURES="installsources" is set...

I lean towards patching tde-cmake to make them conditional and then disable them either during gentoo build or at least when FEATURES="installsources" is set...
Collaborator

I lean towards patching tde-cmake to make them conditional and then disable them either during gentoo build or at least when FEATURES="installsources" is set...

You can try making a suggestion for changing tde-cmake. I can assume that these flags were needed to ensure that the source files were not tied to a specific path when debugging. Since Gentoo allows you to install sources using FEATURES="installsources", relative paths are not needed when building. If there is no need to change the location of the binary files, then these flags are not needed.

> I lean towards patching tde-cmake to make them conditional and then disable them either during gentoo build or at least when FEATURES="installsources" is set... You can try making a suggestion for changing tde-cmake. I can assume that these flags were needed to ensure that the source files were not tied to a specific path when debugging. Since Gentoo allows you to install sources using FEATURES="installsources", relative paths are not needed when building. If there is no need to change the location of the binary files, then these flags are not needed.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#331
Loading…
There is no content yet.