Fixed tdemultimedia-tdeioslaves, fix for issue #208 #244

Merged
SlavekB merged 1 commits from feat/tdemultimedia into master 2 years ago
Collaborator

Since tdemultimedia-tdeioslaves cannot be built without kscd, it makes no sense to build it separately. Solved to add tdemultimedia-tdeioslaves to kscd.

Since tdemultimedia-tdeioslaves cannot be built without kscd, it makes no sense to build it separately. Solved to add tdemultimedia-tdeioslaves to kscd.
Owner

Although tdemultimedia-tdeioslaves can not be built without KSCD, it is possible to build KSCD without tdemultimedia-tdeioslaves. Is it really wanted to force KDSC dependence on tdemultimedia-tdeioslaves?

Although tdemultimedia-tdeioslaves can not be built without KSCD, it is possible to build KSCD without tdemultimedia-tdeioslaves. Is it really wanted to force KDSC dependence on tdemultimedia-tdeioslaves?
ormorph force-pushed feat/tdemultimedia from 6d3e9e0e0f to 44726dcfbb 2 years ago
Poster
Collaborator

Is it really wanted to force KDSC dependence on tdemultimedia-tdeioslaves?

KDSC is independent of tdemultimedia-tdeioslaves. Tdemultimedia-tdeioslaves is included in the KDSC with the cdparanoia flag. With the cdparanoia flag turned off, KDSC can still be built without adding tdemultimedia-tdeioslaves. By default, the cdparanoia flag is off. The tdemultimedia-tdeioslaves package is required for kaudiocreator to work.
I can make the tdemultimedia-tdeioslaves package separate, but then tdemultimedia-tdeioslaves will be built with KDSC and then KDSC will be removed. So far, this is the only solution to make tdemultimedia-tdeioslaves a separate package.

> Is it really wanted to force KDSC dependence on tdemultimedia-tdeioslaves? KDSC is independent of tdemultimedia-tdeioslaves. Tdemultimedia-tdeioslaves is included in the KDSC with the `cdparanoia` flag. With the `cdparanoia` flag turned off, KDSC can still be built without adding tdemultimedia-tdeioslaves. By default, the `cdparanoia` flag is off. The tdemultimedia-tdeioslaves package is required for kaudiocreator to work. I can make the tdemultimedia-tdeioslaves package separate, but then tdemultimedia-tdeioslaves will be built with KDSC and then KDSC will be removed. So far, this is the only solution to make tdemultimedia-tdeioslaves a separate package.
ormorph force-pushed feat/tdemultimedia from 44726dcfbb to ed450c598c 2 years ago
ormorph changed title from Tdemultimedia-tdeioslaves added to kscd, fix for issue #208 to Fixed tdemultimedia-tdeioslaves, fix for issue #208 2 years ago
Poster
Collaborator

Added fix for tdemultimedia-tdeioslaves. Removed trinity-base/kscd dependency from tdemultimedia-tdeioslaves. The only drawback here is that the assembly time will increase.

Added fix for tdemultimedia-tdeioslaves. Removed trinity-base/kscd dependency from tdemultimedia-tdeioslaves. The only drawback here is that the assembly time will increase.
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

It seems good.
Thank you.

It seems good. Thank you.
SlavekB merged commit ed450c598c into master 2 years ago
SlavekB deleted branch feat/tdemultimedia 2 years ago
SlavekB added this to the R14.0.12 release milestone 2 years ago

Reviewers

SlavekB approved these changes 2 years ago
The pull request has been merged as ed450c598c.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#244
Loading…
There is no content yet.