DEB python-trinity: drop python 2 support. #181

Merged
MicheleC merged 1 commits from deb/python-trinity/drop-python2 into master 1 year ago
Owner

To be built with TDE/python-trinity#5

To be built with TDE/python-trinity#5
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC requested review from SlavekB 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC changed title from DEB python-trinity: drop python 2 support. to WIP: (READY) DEB python-trinity: drop python 2 support. 1 year ago
MicheleC force-pushed deb/python-trinity/drop-python2 from d580fd6c1a to 7f9af8b02c 1 year ago
Poster
Owner

Small change to detection of python in debian/rules, to make it uniform with sip4-tqt and pytqt
PYTHONS := $(shell py3versions -vd)

Small change to detection of python in debian/rules, to make it uniform with sip4-tqt and pytqt `PYTHONS := $(shell py3versions -vd)`
MicheleC added a new dependency 1 year ago
SlavekB requested review from SlavekB 1 year ago
SlavekB commented 1 year ago
Owner

It seems that I was too quick to approve, although there are a number of things that need to be done here. I will be pushing an additional patch soon.

It seems that I was too quick to approve, although there are a number of things that need to be done here. I will be pushing an additional patch soon.
SlavekB commented 1 year ago
Owner

The additional patch completes the changes regarding the change of support from Python 2 to Python 3. There it was necessary to use the python3- prefix for packages with Python modules. At the same time, I renamed the packages from python-trinity to pytde, similar to what was done for PyTQt.

After revising, it will definitely be appropriate to squash both commits. I am hesitating whether to separate the python-trinity => pytde renaming as a separate commit or leave it within one commit as it is now. What is your opinion?

Anyway, great job Michele – thank you!

The additional patch completes the changes regarding the change of support from Python 2 to Python 3. There it was necessary to use the `python3-` prefix for packages with Python modules. At the same time, I renamed the packages from `python-trinity` to `pytde`, similar to what was done for PyTQt. After revising, it will definitely be appropriate to squash both commits. I am hesitating whether to separate the python-trinity => pytde renaming as a separate commit or leave it within one commit as it is now. What is your opinion? Anyway, great job Michele – thank you!
Poster
Owner

I think we can keep the renaming commit separate. It looks cleaner that way.

I think we can keep the renaming commit separate. It looks cleaner that way.
MicheleC force-pushed deb/python-trinity/drop-python2 from 227524e24e to f8632c634e 1 year ago
SlavekB commented 1 year ago
Owner

Yes, I will do it as a separate commit. I'm still hesitating whether to leave one -trinity (ie pytde-trinity) or not. What do you think?

Yes, I will do it as a separate commit. I'm still hesitating whether to leave one `-trinity` (ie `pytde-trinity`) or not. What do you think?
Poster
Owner

Looking at sip4-tqt and pytqt, I think we can simply rename it as pytde, without the -trinity extension. The tde in the name makes it clear that it relates to TDE.
Likewise we could drop -trinity in the pytde extensions packages too.

Looking at sip4-tqt and pytqt, I think we can simply rename it as pytde, without the -trinity extension. The `tde` in the name makes it clear that it relates to TDE. Likewise we could drop `-trinity` in the pytde extensions packages too.
SlavekB force-pushed deb/python-trinity/drop-python2 from f8632c634e to aca97c3c0e 1 year ago
SlavekB force-pushed deb/python-trinity/drop-python2 from aca97c3c0e to 1b66a48028 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks ready.

It looks ready.
MicheleC force-pushed deb/python-trinity/drop-python2 from 1b66a48028 to 328096e4ed 1 year ago
MicheleC changed title from WIP: (READY) DEB python-trinity: drop python 2 support. to DEB python-trinity: drop python 2 support. 1 year ago
MicheleC merged commit 328096e4ed into master 1 year ago
MicheleC deleted branch deb/python-trinity/drop-python2 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as 328096e4ed.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Depends on
Reference: TDE/tde-packaging#181
Loading…
There is no content yet.