DEB tde-guidance: disable packaging of wineconfig due to old config GUI. #209

Merged
MicheleC merged 1 commits from deb/tde-guidance/disable-wineconfig into master 1 year ago
Owner

As per title.
wineconfig GUI is old and it is recommened to use the configuration dialogs that come with wine.

As per title. wineconfig GUI is old and it is recommened to use the configuration dialogs that come with wine.
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
e4c86ea5ce
DEB tde-guidance: disable packaging of wineconfig due to old config GUI.
MicheleC requested review from SlavekB 1 year ago
SlavekB requested changes 1 year ago
SlavekB left a comment
Owner

Much of the patch needs to edit – see comment that has a major impact.

Much of the patch needs to edit – see comment that has a major impact.
/usr/lib/python*/dist-packages/tde-guidance/MicroHAL.py
SlavekB commented 1 year ago
Owner

Backend MicroHAL.py is used in mountconfig, not wineconfig. So we still need a guidance-backends-trinity package! This also affects all changes related to the deletion of the package guidance-backends-trinity, so I will not give a comment on all other places now.

Backend `MicroHAL.py` is used in `mountconfig`, not `wineconfig`. So we still need a `guidance-backends-trinity` package! This also affects all changes related to the deletion of the package `guidance-backends-trinity`, so I will not give a comment on all other places now.
Poster
Owner

ah thanks, I missed that. PR updated.

ah thanks, I missed that. PR updated.
MicheleC force-pushed deb/tde-guidance/disable-wineconfig from e4c86ea5ce to 7e25b15fbf 1 year ago
SlavekB requested changes 1 year ago
SlavekB left a comment
Owner

You need to make a third attempt – see comment 😉

You need to make a third attempt – see comment 😉
/usr/lib/python*/dist-packages/tde-guidance/MicroHAL.py
/usr/lib/python*/dist-packages/tde-guidance/drivedetect.py
SlavekB commented 1 year ago
Owner

Although drivedetect may give the impression that is related to MicroHAL, it is not – drivedetect is really used in wineconfig and can go away.

Although `drivedetect` may give the impression that is related to `MicroHAL`, it is not – `drivedetect` is really used in `wineconfig` and can go away.
Poster
Owner

Updated again. I guess I should not have rushed the previous commit :-)

Updated again. I guess I should not have rushed the previous commit :-)
MicheleC marked this conversation as resolved
MicheleC force-pushed deb/tde-guidance/disable-wineconfig from 7e25b15fbf to ef29ae1da3 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

Now it looks like a successful attempt 😺

Now it looks like a successful attempt 😺
MicheleC merged commit ef29ae1da3 into master 1 year ago
MicheleC deleted branch deb/tde-guidance/disable-wineconfig 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as ef29ae1da3.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging#209
Loading…
There is no content yet.