FreeBSD imlib: basename defined in libgen.h #300

Merged
SlavekB merged 1 commits from freebsd-imlim-colors-patch into master 2 weeks ago
denis commented 4 weeks ago
Collaborator

basename defined in libgen.h in FreeBSD

Signed-off-by: Denis Kozadaev denis@dilos.org

basename defined in libgen.h in FreeBSD Signed-off-by: Denis Kozadaev <denis@dilos.org>
denis added 1 commit 4 weeks ago
c87b509891
FreeBSD: basedir defined in libgen.h
SlavekB requested changes 4 weeks ago
SlavekB left a comment
Owner

Patch can be universal independently of the system – #ifdef is not needed.

Patch can be universal independently of the system – `#ifdef` is not needed.
#endif
+#ifdef __FreeBSD__
+#include <libgen.h>
Owner

This seems to be not specific to FreeBSD, but libgen.h can be included independently of the system. You can remove #ifdef.

This seems to be not specific to FreeBSD, but `libgen.h` can be included independently of the system. You can remove `#ifdef`.
denis force-pushed freebsd-imlim-colors-patch from c87b509891 to 3e80712653 4 weeks ago
denis force-pushed freebsd-imlim-colors-patch from 3e80712653 to f7ad22e001 4 weeks ago
denis changed title from FreeBSD: basename defined in libgen.h to system independent: basename defined in libgen.h 4 weeks ago
denis force-pushed freebsd-imlim-colors-patch from f7ad22e001 to b530b759da 4 weeks ago
denis force-pushed freebsd-imlim-colors-patch from b530b759da to d99ffb5857 4 weeks ago
denis changed title from system independent: basename defined in libgen.h to FreeBSD imlib: basename defined in libgen.h 4 weeks ago
Owner

It seems that it will require a more comprehensive fix, because there are two variants of basename – see https://man7.org/linux/man-pages/man3/basename.3.html. We will need to detect whether the GNU variant of basename in string.h or POSIX variants in libgen.h is available.

It seems that it will require a more comprehensive fix, because there are two variants of `basename` – see https://man7.org/linux/man-pages/man3/basename.3.html. We will need to detect whether the GNU variant of `basename` in `string.h` or POSIX variants in `libgen.h` is available.
SlavekB force-pushed freebsd-imlim-colors-patch from d99ffb5857 to a4f44d553c 2 weeks ago
SlavekB requested review from Owners 2 weeks ago
SlavekB requested review from Packagers 2 weeks ago
SlavekB approved these changes 2 weeks ago
SlavekB left a comment
Owner

All works as intended.

All works as intended.
SlavekB merged commit a4f44d553c into master 2 weeks ago
SlavekB deleted branch freebsd-imlim-colors-patch 2 weeks ago
SlavekB added this to the R14.1.2 release milestone 2 weeks ago
MicheleC approved these changes 2 weeks ago

Reviewers

SlavekB approved these changes 2 weeks ago
MicheleC approved these changes 2 weeks ago
TDE/Packagers was requested for review 2 weeks ago
The pull request has been merged as a4f44d553c.
Sign in to join this conversation.
No reviewers
TDE/Packagers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging#300
Loading…
There is no content yet.