Build issue: pinentry-tqt FTBFS in r14.1.2 #305

Basic information

TDE version: 14.1.2
Distribution: Fedora 38
Hardware: amd64

Description

Some times ago, someone contributed to the pinentry projet to add TQT3 support.

Project page: https://github.com/gpg/pinentry

Alas, changes in TQT3 causes the pinentry-tqt fails to build.

Steps to reproduce

Build pinentry 1.3.0 with option --enable-pinentry-tqt

Screenshots

make[3]: Entering directory '/tmp/BUILD.fc39.x86_64/pinentry-tqt-1.3.0/tqt'
g++ -DHAVE_CONFIG_H -I. -I..  -I/usr/include/libsecret-1 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -pthread -I/usr/include/libassuan2   -I.. -I../secmem -I/usr/include/ncursesw -I../pinentry -Wall -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -I/usr/include/tqt3 -I/usr/include/tqt -include tqt.h -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64   -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -c -o pinentrydialog.o pinentrydialog.cpp
In file included from secqlineedit.h:26,
                 from pinentrydialog.cpp:28:
secqstring.h:128:5: error: ‘QT_STATIC_CONST’ does not name a type
  128 |     QT_STATIC_CONST SecTQString null;
      |     ^~~~~~~~~~~~~~~
pinentrydialog.cpp: In constructor ‘PinEntryDialog::PinEntryDialog(TQWidget*, const char*, bool, bool)’:
pinentrydialog.cpp:87:25: error: ‘clicked’ was not declared in this scope
   87 |   connect( _ok, SIGNAL( clicked() ),
      |                         ^~~~~~~
pinentrydialog.cpp:87:17: error: ‘SIGNAL’ was not declared in this scope; did you mean ‘TQ_SIGNAL’?
   87 |   connect( _ok, SIGNAL( clicked() ),
      |                 ^~~~~~
      |                 TQ_SIGNAL
pinentrydialog.cpp:91:40: error: expected primary-expression before ‘const’
   91 |   connect( _edit, SIGNAL( textModified(const SecTQString&) ),
      |                                        ^~~~~
pinentrydialog.cpp:91:27: error: ‘textModified’ was not declared in this scope
   91 |   connect( _edit, SIGNAL( textModified(const SecTQString&) ),
      |                           ^~~~~~~~~~~~
pinentrydialog.cpp:92:38: error: expected primary-expression before ‘const’
   92 |            this, SLOT( updateQuality(const SecTQString&) ) );
      |                                      ^~~~~
pinentrydialog.cpp:92:18: error: ‘SLOT’ was not declared in this scope; did you mean ‘TQ_SLOT’?
   92 |            this, SLOT( updateQuality(const SecTQString&) ) );
      |                  ^~~~
      |                  TQ_SLOT
pinentrydialog.cpp:93:27: error: ‘backspacePressed’ was not declared in this scope
   93 |   connect (_edit, SIGNAL (backspacePressed()),
      |                           ^~~~~~~~~~~~~~~~

## Basic information - TDE version: 14.1.2 - Distribution: Fedora 38 - Hardware: amd64  ## Description Some times ago, someone contributed to the pinentry projet to add TQT3 support. Project page: https://github.com/gpg/pinentry Alas, changes in TQT3 causes the pinentry-tqt fails to build. ## Steps to reproduce Build pinentry 1.3.0 with option --enable-pinentry-tqt ## Screenshots ``` make[3]: Entering directory '/tmp/BUILD.fc39.x86_64/pinentry-tqt-1.3.0/tqt' g++ -DHAVE_CONFIG_H -I. -I.. -I/usr/include/libsecret-1 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -pthread -I/usr/include/libassuan2 -I.. -I../secmem -I/usr/include/ncursesw -I../pinentry -Wall -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -I/usr/include/tqt3 -I/usr/include/tqt -include tqt.h -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -c -o pinentrydialog.o pinentrydialog.cpp In file included from secqlineedit.h:26, from pinentrydialog.cpp:28: secqstring.h:128:5: error: ‘QT_STATIC_CONST’ does not name a type 128 | QT_STATIC_CONST SecTQString null; | ^~~~~~~~~~~~~~~ pinentrydialog.cpp: In constructor ‘PinEntryDialog::PinEntryDialog(TQWidget*, const char*, bool, bool)’: pinentrydialog.cpp:87:25: error: ‘clicked’ was not declared in this scope 87 | connect( _ok, SIGNAL( clicked() ), | ^~~~~~~ pinentrydialog.cpp:87:17: error: ‘SIGNAL’ was not declared in this scope; did you mean ‘TQ_SIGNAL’? 87 | connect( _ok, SIGNAL( clicked() ), | ^~~~~~ | TQ_SIGNAL pinentrydialog.cpp:91:40: error: expected primary-expression before ‘const’ 91 | connect( _edit, SIGNAL( textModified(const SecTQString&) ), | ^~~~~ pinentrydialog.cpp:91:27: error: ‘textModified’ was not declared in this scope 91 | connect( _edit, SIGNAL( textModified(const SecTQString&) ), | ^~~~~~~~~~~~ pinentrydialog.cpp:92:38: error: expected primary-expression before ‘const’ 92 | this, SLOT( updateQuality(const SecTQString&) ) ); | ^~~~~ pinentrydialog.cpp:92:18: error: ‘SLOT’ was not declared in this scope; did you mean ‘TQ_SLOT’? 92 | this, SLOT( updateQuality(const SecTQString&) ) ); | ^~~~ | TQ_SLOT pinentrydialog.cpp:93:27: error: ‘backspacePressed’ was not declared in this scope 93 | connect (_edit, SIGNAL (backspacePressed()), | ^~~~~~~~~~~~~~~~ ```

You need additional patch as is in TDE/extra-dependencies#16.

Tnanks @SlavekB , it now builds correctly, even with version 1.3.0.