dilos-pack-tqt3 #22

Manually merged
TDE merged 1 commits from dilos-pack-tqt3 into master 5 years ago
denis commented 5 years ago
Collaborator

try to create a package for DilOS platform

try to create a package for DilOS platform
Owner

Please, BASEDIR is a variable used specifically for DilOS?

I would expect to use it for example to choose whether to install to /usr or to /opt/trinity – basically to determine the prefix. But I do not understand using BASEDIR to create a parallel tree? Please, can you explain it to me?

Please, `BASEDIR` is a variable used specifically for DilOS? I would expect to use it for example to choose whether to install to `/usr` or to `/opt/trinity` – basically to determine the prefix. But I do not understand using `BASEDIR` to create a parallel tree? Please, can you explain it to me?
denis commented 5 years ago
Poster
Collaborator

just a test...

just a test...
denis commented 5 years ago
Poster
Collaborator

illumos based systems use BE (boot environment) to upgrade the system.
BE is another location of the system (alternative root)
we modified apt, dpkg and some other tools for this purpose,
i.e. BASEDIR, it is a platform specific issue.

about BEs:
https://docs.oracle.com/cd/E23824_01/html/E21801/index.html

illumos based systems use BE (boot environment) to upgrade the system. BE is another location of the system (alternative root) we modified apt, dpkg and some other tools for this purpose, i.e. BASEDIR, it is a platform specific issue. about BEs: https://docs.oracle.com/cd/E23824_01/html/E21801/index.html
Owner

Great, thank you, that's what I needed. Now I understand the meaning of this variable.

One more question: Did you consider that the dilos-g++ directory could be added to the source tree of TQt3?

Great, thank you, that's what I needed. Now I understand the meaning of this variable. One more question: Did you consider that the `dilos-g++` directory could be added to the source tree of TQt3?
denis commented 5 years ago
Poster
Collaborator

of course, add it in the main tree

of course, add it in the main tree
Owner

Great. In that case you can create a PR to add DilOS mkspec to TDE/tqt3. I assume that after its merging it will be possible to modify this PR to use the files contained in TQt3 instead of the files contained here?

Great. In that case you can create a PR to add DilOS mkspec to [TDE/tqt3](../tqt3). I assume that after its merging it will be possible to modify this PR to use the files contained in TQt3 instead of the files contained here?
Owner

What is the status of this PR, given the new mkspecs files for tqt3 have been merged?

What is the status of this PR, given the new mkspecs files for tqt3 have been merged?
Owner

Signed-off-by should be added here for each commit. Since @denis has agreed to DCO, we could possibly add his signature.

Signed-off-by should be added here for each commit. Since @denis has agreed to DCO, we could possibly add his signature.
denis commented 5 years ago
Poster
Collaborator

please check it and sorry for the delay

please check it and sorry for the delay
Owner

There are some shortcomings. First, the Signed-off-by should be on every commit. Second, there is an unnecessary merge commit. But don't worry about it – either I or Michele will fix it for this PR. Over time you will gain further experience with git.

There are some shortcomings. First, the Signed-off-by should be on every commit. Second, there is an unnecessary merge commit. But don't worry about it – either I or Michele will fix it for this PR. Over time you will gain further experience with git.
denis commented 5 years ago
Poster
Collaborator

Thank you, guys. I hope my next commits will be correct

Thank you, guys. I hope my next commits will be correct
Owner
  • Rebased to current HEAD.
  • Added your Signed-off-by line.
  • Commits related to mkspecs squashed into first commit.
  • Added prefix DilOS: in commit log.
* Rebased to current HEAD. * Added your Signed-off-by line. * Commits related to mkspecs squashed into first commit. * Added prefix DilOS: in commit log.
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

After comparing Debian × DilOS packages, I have an additional question – see comments below.

After comparing Debian × DilOS packages, I have an additional question – see comments below.
before you send a bugreport.
Package: libtqt3-headers
Architecture: any
Owner

For Debian packages, this package is now "all", so it is the same for all architectures. For DilOS, the intent is that the package is "any", so built for each architecture?

For Debian packages, this package is now "all", so it is the same for all architectures. For DilOS, the intent is that the package is "any", so built for each architecture?
denis commented 5 years ago
Poster
Collaborator

at this moment we have two architectures: x86_64 and sparc,
if I specify here "all", sparc failed because some headers placed into a wrong path,
for example, amd64, but it finds in sparcv9 directory

at this moment we have two architectures: x86_64 and sparc, if I specify here "all", sparc failed because some headers placed into a wrong path, for example, amd64, but it finds in sparcv9 directory
Owner

This is strange because both the libtqt3-headers and libtqt3-compat-headers packages contain no architecture-dependent files, and they are all usually installed in a general directory – for example, /usr/include/tqt3.

What files are installed in your architecture-specific directory in your package?

This is strange because both the libtqt3-headers and libtqt3-compat-headers packages contain no architecture-dependent files, and they are all usually installed in a general directory – for example, `/usr/include/tqt3`. What files are installed in your architecture-specific directory in your package?
denis commented 5 years ago
Poster
Collaborator

ok, you are right, I just install this packages on sparc, there are no platform specific files

ok, you are right, I just install this packages on sparc, there are no platform specific files
Owner

So there seems to be nothing to prevent "any" from being changed to "all" for these packages. Therefore, I modified the commit in this way.

So there seems to be nothing to prevent "any" from being changed to "all" for these packages. Therefore, I modified the commit in this way.
denis commented 5 years ago
Poster
Collaborator

of course, I hope this change will not affect the sparc build

of course, I hope this change will not affect the sparc build
have to install this package.
Package: libtqt3-compat-headers
Architecture: any
Owner

For Debian packages, this package is now "all", so it is the same for all architectures. For DilOS, the intent is that the package is "any", so built for each architecture?

For Debian packages, this package is now "all", so it is the same for all architectures. For DilOS, the intent is that the package is "any", so built for each architecture?
SlavekB closed this pull request 5 years ago
TDE closed this pull request 5 years ago
SlavekB deleted branch dilos-pack-tqt3 5 years ago
SlavekB added this to the R14.0.7 release milestone 5 years ago
The pull request has been manually merged as 20127da5fe.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging#22
Loading…
There is no content yet.