Labels Milestones

Fix translations build #2

Manually merged

Ray-V merged 1 commits from feat/fix_translations into master 4 years ago

Conversation 2 Commits 1 Files Changed 5

Ray-V commented 4 years ago

Collaborator

The translations/CMakeLists.txt file for tde-style-lipstick doesn't build the 'de' locale file.

The input parameters for tde_create_translation aren't suitable for the directory structure and naming of the source files.

A format that works is as used for gtk-qt-engine/po/CMakeLists.txt

The translations/CMakeLists.txt file for tde-style-lipstick doesn't build the 'de' locale file. The input parameters for tde_create_translation aren't suitable for the directory structure and naming of the source files. A format that works is as used for gtk-qt-engine/po/CMakeLists.txt

Ray-V added the PR/wip label 4 years ago

SlavekB commented 4 years ago

Owner

Thank you for notification of this problem! Instead of your patch that needs changes, I will change the layout of the directories with the translations to be the same as it will be used for all projects.

Thank you for notification of this problem! Instead of your patch that needs changes, I will change the layout of the directories with the translations to be the same as it will be used for all projects.

SlavekB commented 4 years ago

Owner

One more note: Please write a commit log message before the Signed-off-by line, not after it.

One more note: Please write a commit log message before the Signed-off-by line, not after it.

SlavekB removed the PR/wip label 4 years ago

SlavekB changed title from WIP: fix translations build to Fix translations build 4 years ago

SlavekB added this to the R14.0.8 release milestone 4 years ago

Ray-V closed this pull request 4 years ago

SlavekB deleted branch feat/fix_translations 4 years ago

The pull request has been manually merged as ca4e2cb3e7.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.8 release

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-style-lipstik#2

Write Preview

Loading…

Cancel

Save

There is no content yet.