#2 QtCurve 1.7.1 backported to Trinity, but no config module and image background does not work

Open
opened 1 month ago by tch · 11 comments
tch commented 1 month ago

Hello.

I've just backported the changes of QtCurve 1.7.0 and 1.7.1 to Trinity's version (1.6.2) of QtCurve. (http://mirror.git.trinitydesktop.org/gitea/TDE/tde-style-qtcurve)

I attached the patch.

I've tested the built qtcurve.so and qtcurve.la and they are working. However, i've noticed, that the configuration module does not build. Not even with the original sources of 1.6.2.

Also i am unable to set the background image for panels and menus from the config file. A decade ago i had a converstation with original author Craig Drummond here: https://www.cinnamon-look.org/p/1005552/show/page/21 He advised me what to do, but 1.6.2 did not supported those options; it was introduced in 1.7.0, that's why i backported it, but it still not works.

Any ideas on that?

Hello. I've just backported the changes of QtCurve 1.7.0 and 1.7.1 to Trinity's version (1.6.2) of QtCurve. (http://mirror.git.trinitydesktop.org/gitea/TDE/tde-style-qtcurve) I attached the patch. I've tested the built qtcurve.so and qtcurve.la and they are working. However, i've noticed, that the configuration module does not build. Not even with the original sources of 1.6.2. Also i am unable to set the background image for panels and menus from the config file. A decade ago i had a converstation with original author Craig Drummond here: https://www.cinnamon-look.org/p/1005552/show/page/21 He advised me what to do, but 1.6.2 did not supported those options; it was introduced in 1.7.0, that's why i backported it, but it still not works. Any ideas on that?
MicheleC commented 1 month ago
Owner

Patch is available on bugzilla bug 3073

Patch is available on bugzilla [bug 3073](https://bugs.trinitydesktop.org/show_bug.cgi?id=3073)
tch commented 1 month ago
Poster

I could swear, that i attached the patch here too... Attaching again.

Anyway, any ideas about the config module not building or why the image as window/menu background is not working?

I could swear, that i attached the patch here too... Attaching again. Anyway, any ideas about the config module not building or why the image as window/menu background is not working?
tch commented 1 month ago
Poster

Yep, upload does not work for me. Neither edit...

Yep, upload does not work for me. Neither edit...
SlavekB commented 1 month ago
Owner

Instead of inserting a patch as comments or attachments, the better way is to create a branch, apply the patch, push as a new commit, and create a pull-request. See the TGW tutorial on the wiki.

Instead of inserting a patch as comments or attachments, the better way is to create a branch, apply the patch, push as a new commit, and create a pull-request. See the [TGW tutorial on the wiki](https://wiki.trinitydesktop.org/TDE_Gitea_Workspace).
MicheleC commented 1 month ago
Owner

@tch: thanks anyway for trying crating a PR (replying here to your comment on bug 3073). When I look at the patch I will also look at the config module and background problem.

@tch: thanks anyway for trying crating a PR (replying here to your comment on bug 3073). When I look at the patch I will also look at the config module and background problem.
tch commented 1 month ago
Poster

@SlavekB: Tried, but the authentication has failed.

@MicheleC: Ok, then.

BTW, i've checked the modifications between the steps of 1.7.1->1.8.0->1.8.1->1.8.2->1.8.3->1.8.4->1.8.5 and it's not much. It can be done in an afternoon, just like this one. Although i found nothing between 1.8.4 and 1.8.5 beside the changelog. Maybe all modifications were done in the “common” folder, which is missing from the archives.

@SlavekB: Tried, but the authentication has failed. @MicheleC: Ok, then. BTW, i've checked the modifications between the steps of 1.7.1->1.8.0->1.8.1->1.8.2->1.8.3->1.8.4->1.8.5 and it's not much. It can be done in an afternoon, just like this one. Although i found nothing between 1.8.4 and 1.8.5 beside the changelog. Maybe all modifications were done in the "common" folder, which is missing from the archives.
cethyel commented 1 month ago
Collaborator

First: If @tch has trouble creating a branch or uploading his patch maybe he can create a fork in his gitea area.

Second: I'm a bit puzzled with our Qtcurve because I've cloned git://anongit.kde.org/qtcurve.git and when I get back to tag 1.6.2 for instance, I see two extra folders (kwin and kwindconfig).

As a side note, tags from 1.7.2 to 1.8.9 are available.
git show-ref --tags -d

First: If @tch has trouble creating a branch or uploading his patch maybe he can create a fork in his gitea area. Second: I'm a bit puzzled with our Qtcurve because I've cloned **git://anongit.kde.org/qtcurve.git** and when I get back to tag 1.6.2 for instance, I see two extra folders (kwin and kwindconfig). As a side note, tags from 1.7.2 to 1.8.9 are available. **git show-ref --tags -d**
SlavekB commented 1 month ago
Owner

The user @tch is a member of the Contributors team, so there should be no problem with that he can push the new branch. Unfortunately I have no idea if he tried to push directly into the master branch?

The user @tch is a member of the Contributors team, so there should be no problem with that he can push the new branch. Unfortunately I have no idea if he tried to push directly into the master branch?
tch commented 1 month ago
Poster

@cethyel: Those folders for KDE4 and/or KDE5. After 1.8.5 KDE3 was unsupported. Also by first glance, your repository does not contain any KDE3/Qt3 related sources even below 1.8.5.

@SlavekB: About the push issues, the details are in https://bugs.trinitydesktop.org/show_bug.cgi?id=3073

@cethyel: Those folders for KDE4 and/or KDE5. After 1.8.5 KDE3 was unsupported. Also by first glance, your repository does not contain any KDE3/Qt3 related sources even below 1.8.5. @SlavekB: About the push issues, the details are in https://bugs.trinitydesktop.org/show_bug.cgi?id=3073
cethyel commented 1 month ago
Collaborator

@tch
oh that's too bad, I thought that this repository (which, by the way, is not mine) could be of use in your endeavor.

@tch oh that's too bad, I thought that this repository (which, by the way, is not mine) could be of use in your endeavor.
tch commented 1 month ago
Poster

I did not say that it could not, i just said, that i have not found any KDE/Qt3 related part, yet. But thanks anyway.

I did not say that it could not, i just said, that i have not found any KDE/Qt3 related part, yet. But thanks anyway.
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.