#3 Conversion to the cmake building system.

Merged
SlavekB merged 4 commits from feat/cmakeConv into master 1 month ago
cethyel commented 1 month ago
There is no content yet.
cethyel added the
PR/wip
label 1 month ago
cethyel commented 1 month ago
Poster

@SlavekB when you’ve got time can you have a look into the symbols visibility?

@SlavekB when you've got time can you have a look into the symbols visibility?
SlavekB commented 1 month ago
Owner

@SlavekB when you’ve got time can you have a look into the symbols visibility?

There seems to be no need for any additional care regarding hidden visibility, as the result is a standalone application without additional libraries and modules.

> @SlavekB when you've got time can you have a look into the symbols visibility? There seems to be no need for any additional care regarding hidden visibility, as the result is a standalone application without additional libraries and modules.
SlavekB reviewed 1 month ago
SlavekB left a comment

It looks good. Here are some small comments.

systemsettings/menu/CMakeLists.txt
@@ -0,0 +1,51 @@
##### other data

install(
SlavekB commented 1 month ago

These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use tde_create_translated_desktop here.

These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use `tde_create_translated_desktop` here.
systemsettings/menu/CMakeLists.txt
@@ -0,0 +11,4 @@
DESTINATION ${XDG_APPS_INSTALL_DIR}
)

install(
SlavekB commented 1 month ago

These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use tde_create_translated_desktop here.

These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use `tde_create_translated_desktop` here.
SlavekB commented 1 month ago
Owner

Note: I have a patch for ascii-cast ready – it’s single line.

Note: I have a patch for ascii-cast ready – it's single line.
cethyel commented 1 month ago
Poster

the desktop files installation have been added to the cmake conversion.

the desktop files installation have been added to the cmake conversion.
SlavekB commented 1 month ago
Owner
  • Fixed and added the use of tde_create_translated_desktop.
  • Added commit to resolve ascii-cast.
  • The first step of moving translations to a new layout has been performed.
+ Fixed and added the use of tde_create_translated_desktop. + Added commit to resolve ascii-cast. + The first step of moving translations to a new layout has been performed.
SlavekB commented 1 month ago
Owner

I wanted to move forward and merge it, because everything looks good, but subsequently I noticed that in tde-packaging for Debian there is a man page. Will you add it to the main tree?

I wanted to move forward and merge it, because everything looks good, but subsequently I noticed that in tde-packaging for Debian there is a man page. Will you add it to the main tree?
SlavekB commented 1 month ago
Owner

One more note: Because the project name is set to tde-systemsettings, the translation catalogs are now installed as tde-systemsettings.mo.

This is basically not a problem – on the contrary, it can be an advantage that it is not a very common name. However, there will need to be an adjustment in systemsettings/main.cpp for TDELocale::setMainCatalogue(...) to set tde-systemsettings instead of the current systemsettings.

What is your opinion – keep the new name of the catalog or revert to the previous one?

One more note: Because the project name is set to `tde-systemsettings`, the translation catalogs are now installed as `tde-systemsettings.mo`. This is basically not a problem – on the contrary, it can be an advantage that it is not a very common name. However, there will need to be an adjustment in `systemsettings/main.cpp` for `TDELocale::setMainCatalogue(...)` to set `tde-systemsettings` instead of the current `systemsettings`. What is your opinion – keep the new name of the catalog or revert to the previous one?
cethyel commented 1 month ago
Poster

...I noticed that in tde-packaging for Debian there is a man page...

Man page added, please test.

>...I noticed that in tde-packaging for Debian there is a man page... Man page added, please test.
cethyel commented 1 month ago
Poster

What is your opinion – keep the new name of the catalog or revert to the previous one?

Looks to me that a thorough job should change the name/ocurrence: systemsettings vs tde-systemsettings everywhere in this module; namely code, config and desktop files alike, help and man page...
It shouldn’t be difficult but time consumming and I don’t feel like doing It. 😩

> What is your opinion – keep the new name of the catalog or revert to the previous one? Looks to me that a thorough job should change the name/ocurrence: **systemsettings** vs **tde-systemsettings** everywhere in this module; namely code, config and desktop files alike, help and man page... It shouldn't be difficult but time consumming and I don't feel like doing It. :weary:
SlavekB commented 1 month ago
Owner

...I noticed that in tde-packaging for Debian there is a man page...

Man page added, please test.

Excellent, tested, everything is fine.

> >...I noticed that in tde-packaging for Debian there is a man page... > > Man page added, please test. > > Excellent, tested, everything is fine.
SlavekB commented 1 month ago
Owner

What is your opinion – keep the new name of the catalog or revert to the previous one?

Looks to me that a thorough job should change the name/ocurrence: systemsettings vs tde-systemsettings everywhere in this module; namely code, config and desktop files alike, help and man page...
It shouldn’t be difficult but time consumming and I don’t feel like doing It. 😩

Ok, that’s not a problem – we can move the translations to be installed as systemsettings.mo, as it was before.

> > What is your opinion – keep the new name of the catalog or revert to the previous one? > > Looks to me that a thorough job should change the name/ocurrence: **systemsettings** vs **tde-systemsettings** everywhere in this module; namely code, config and desktop files alike, help and man page... > It shouldn't be difficult but time consumming and I don't feel like doing It. :weary: Ok, that's not a problem – we can move the translations to be installed as `systemsettings.mo`, as it was before.
SlavekB changed title from WIP:Conversion to the cmake building system. to Conversion to the cmake building system. 1 month ago
SlavekB removed the
PR/wip
label 1 month ago
SlavekB merged commit b3a20cdb91 into master 1 month ago
SlavekB deleted branch feat/cmakeConv 1 month ago
SlavekB added this to the R14.0.9 release milestone 1 month ago
The pull request has been merged as b3a20cdb91.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.