Conversion to the cmake building system. #3
Zusammengeführt
SlavekB
hat 4 Commits von feat/cmakeConv nach master vor 4 Jahren zusammengeführt
Keine Reviewer
Kein Label
Niemand zuständig
2 Beteiligte
Nachrichten
Fällig am
Kein Fälligkeitsdatum gesetzt.
Abhängigkeiten
Keine Abhängigkeiten gesetzt.
Referenz: TDE/tde-systemsettings#3
Laden…
In neuem Issue referenzieren
Hier gibt es bis jetzt noch keinen Inhalt.
Branch „feat/cmakeConv“ löschen
Das Löschen eines Branches ist permanent. Es KANN NICHT rückgängig gemacht werden. Fortfahren?
@SlavekB when you've got time can you have a look into the symbols visibility?
There seems to be no need for any additional care regarding hidden visibility, as the result is a standalone application without additional libraries and modules.
It looks good. Here are some small comments.
##### other datainstall(These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use
tde_create_translated_desktophere.DESTINATION ${XDG_APPS_INSTALL_DIR})install(These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use
tde_create_translated_desktophere.Note: I have a patch for ascii-cast ready – it's single line.
the desktop files installation have been added to the cmake conversion.
I wanted to move forward and merge it, because everything looks good, but subsequently I noticed that in tde-packaging for Debian there is a man page. Will you add it to the main tree?
One more note: Because the project name is set to
tde-systemsettings, the translation catalogs are now installed astde-systemsettings.mo.This is basically not a problem – on the contrary, it can be an advantage that it is not a very common name. However, there will need to be an adjustment in
systemsettings/main.cppforTDELocale::setMainCatalogue(...)to settde-systemsettingsinstead of the currentsystemsettings.What is your opinion – keep the new name of the catalog or revert to the previous one?
Man page added, please test.
Looks to me that a thorough job should change the name/ocurrence: systemsettings vs tde-systemsettings everywhere in this module; namely code, config and desktop files alike, help and man page...
It shouldn't be difficult but time consumming and I don't feel like doing It. 😩
Excellent, tested, everything is fine.
Ok, that's not a problem – we can move the translations to be installed as
systemsettings.mo, as it was before.WIP:Conversion to the cmake building system.zu Conversion to the cmake building system. vor 4 Jahren geändertb3a20cdb91vor 4 Jahren in masterb3a20cdb91gemergt.