Drop python2 support. #15

Merged

MicheleC merged 1 commits from feat/drop-python2 into master

MicheleC commented

Owner

As per title.

MicheleC added 1 commit

fa06f29cf9

Drop python2 support.

Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>

MicheleC added this to the R14.1.0 release milestone

MicheleC requested review from SlavekB

MicheleC referenced this pull request from TDE/tde-packaging

DEB tdeaddons: drop python2 support. #191

SlavekB reviewed

SlavekB left a comment

Owner

It looks good. There is only one comment not directly related to Python 3 conversion.

konq-plugins/imagerotation/orient.py Outdated

													
					    or not tags.has_key('Image Qt::Orientation'):

					  print 'cannot get orientation info in', filename

					if 'Exif Offset' not in tags \

					    or 'Image Qt::Orientation' not in tags:

SlavekB commented

Owner

Although this is not related to the Python 3 conversion, it would be good to remove the unwanted Qt:: in Qt::Orientation, which come a long time ago in commit 395a904bff.

MicheleC commented

Poster

Owner

Good point, that 'Qt::' looked awkward to be honest. PR updated.

MicheleC force-pushed feat/drop-python2 from fa06f29cf9 to 900386ad46

SlavekB approved these changes

SlavekB left a comment

Owner

It looks good.

MicheleC merged commit 900386ad46 into master 1 year ago

MicheleC deleted branch feat/drop-python2

Reviewers

SlavekB approved these changes

The pull request has been merged as 900386ad46.

Sign in to join this conversation.

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdeaddons#15