TDE
/
tdeadmin
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

TDEIO::NetAccess::del should have two parameters in kuser.cpp #4

Merged
SlavekB merged 1 commits from gg-tdeadmin-kuser-netaccess into master 6 years ago
Conversation 2 Commits 1 Files Changed 1
Ghost commented 6 years ago

I’m trying to convert tdeadmin autotools to cmake building system, in the process I’ve run into some deprecated such as TDEIO::NetAccess::del with one parameter, in kuser.cpp.
According to the doc, TDEIO::NetAccess::del should have two parameters.

I’m trying to convert tdeadmin autotools to cmake building system, in the process I’ve run into some deprecated such as TDEIO::NetAccess::del with one parameter, in kuser.cpp. According to the doc, TDEIO::NetAccess::del should have two parameters.
MicheleC commented 6 years ago
Owner

Patch looks good and can be merged.
Tested build tdeadmin on buster with all 4 PR applied: success.

Patch looks good and can be merged. Tested build tdeadmin on buster with all 4 PR applied: success.
SlavekB closed this pull request 6 years ago
SlavekB deleted branch gg-tdeadmin-kuser-netaccess 6 years ago
SlavekB commented 6 years ago
Owner

Merged and pushed upstream.

Merged and pushed upstream.
MicheleC added this to the R14.0.6 release milestone 6 years ago
The pull request has been merged as 4a9ff636bf.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdeadmin#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'gg-tdeadmin-kuser-netaccess'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes