TDE
/
tdeartwork
6
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Add tdeasciiquarium screen saver #16

Merged
MicheleC merged 6 commits from feature/bug_1434 into master 3 years ago
Conversation 9 Commits 6 Files Changed 20
Ghost commented 3 years ago

Upon completion, bug 1434 from Bugzilla may be closed.

Upon completion, bug 1434 from Bugzilla may be closed.
Ghost added the PR/wip label 3 years ago
Ghost added 4 commits 3 years ago
56804d2604
import original source Asciiquarium-0.3.2
89ac49919b
remove scons build support
71fa8c73a5
convert to tqt3 library
270221d13b
convert to tdelibs library
Ghost added 1 commit 3 years ago
088df3aa41
Add cmake build support
SlavekB commented 3 years ago
Owner

Place it in the root directory is not a good choice. Because this is TDE screen saver, it should be in the tdescreensaver/kdesavers directory.

Place it in the root directory is not a good choice. Because this is TDE screen saver, it should be in the `tdescreensaver/kdesavers` directory.
MicheleC commented 3 years ago
Owner

Nice!! Looking forward for this one!

Nice!! Looking forward for this one!
Ghost added 1 commit 3 years ago
6dbd4daab6
change layout of the folders, some cosmetics
Ghost added 1 commit 3 years ago
6962fafca4
some header cleanup, change the app's name into tdeasciiquarius.kss with
Ghost added 1 commit 3 years ago
84d668eaca
silence trigraphs warnings
Ghost added 1 commit 3 years ago
7873acb0c4
add symbols visibility option
Ghost added 1 commit 3 years ago
9b3e04a294
change install location for the desktop file, add a README file
Ghost force-pushed feature/bug_1434 from 9b3e04a294 to a6dd5f7080 3 years ago
Ghost commented 3 years ago
Poster

@SlavekB

For consistency with the other modules:

  • the option BUILD_ALL have been passed to "ON" by default
  • added symbols visibility option
  • passed WITH_ALL_INCLUDED_XSCREENSAVERS and WITH_ARTS options to the value of ${WITH_ALL_OPTIONS}
@SlavekB For consistency with the other modules: - the option BUILD_ALL have been passed to "ON" by default - added symbols visibility option - passed WITH_ALL_INCLUDED_XSCREENSAVERS and WITH_ARTS options to the value of ${WITH_ALL_OPTIONS}
Ghost removed the PR/wip label 3 years ago
Ghost changed title from WIP:Add asciiquarium screen saver to Add tdeasciiquarium screen saver 3 years ago
MicheleC commented 3 years ago
Owner

@Greg: just to be sure, this is ready for testing and merging?

@Greg: just to be sure, this is ready for testing and merging?
Ghost commented 3 years ago
Poster

Yes, please test.

Yes, please test.
Ghost force-pushed feature/bug_1434 from a6dd5f7080 to 18732d51a3 3 years ago
SlavekB commented 3 years ago
Owner

Please can you use for example a prefix "asciiquarium:" in git commit comments? Existing comments without specifying an application seem confusing.

Please can you use for example a prefix "asciiquarium:" in git commit comments? Existing comments without specifying an application seem confusing.
MicheleC commented 3 years ago
Owner

Tested in bullseye, looks beautiful 👍

Tested in bullseye, looks beautiful :+1:
Ghost force-pushed feature/bug_1434 from 18732d51a3 to 13c31402df 3 years ago
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

Thank you Greg, it looks great.

Thank you Greg, it looks great.
MicheleC commented 3 years ago
Owner

Before we merge this, I think it would be good to add in the message of the first commit (cfee243b43) where we took the code from (http://kde-look.org/content/show.php?content=29207 and that the original asciiquarium code is available under GPL@ license (http://www.robobunny.com/projects/asciiquarium, file gpl.txt). Just for the sake of clarity.

Before we merge this, I think it would be good to add in the message of the first commit (cfee243b43) where we took the code from (http://kde-look.org/content/show.php?content=29207 and that the original asciiquarium code is available under GPL@ license (http://www.robobunny.com/projects/asciiquarium, file gpl.txt). Just for the sake of clarity.
Ghost force-pushed feature/bug_1434 from 13c31402df to d9d663485e 3 years ago
MicheleC merged commit d9d663485e into master 3 years ago
MicheleC deleted branch feature/bug_1434 3 years ago
MicheleC commented 3 years ago
Owner

Thanks Greg, excellent work!

Thanks Greg, excellent work!
MicheleC added this to the R14.0.11 release milestone 3 years ago

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as d9d663485e.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdeartwork#16
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feature/bug_1434'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes