release_notes: Use the same method to get the release version (as starttde), minor adjustments #129

Merged
MicheleC merged 1 commits from feat/script-enhancement-release_notes into master 4 years ago
selk commented 4 years ago
Collaborator
There is no content yet.
Owner

Looks good.

As side note, while testing this I noticed the file is not installed in debian distros, so some extra work will be required for that but not as part of this PR.

Looks good. As side note, while testing this I noticed the file is not installed in debian distros, so some extra work will be required for that but not as part of this PR.
selk commented 4 years ago
Poster
Collaborator

What?. I don't understand the part about Debian...

What?. I don't understand the part about Debian...
selk commented 4 years ago
Poster
Collaborator

Well.. a second read tells me that it is about related to the packaging in Debian, I guess...

Well.. a second read tells me that it is about related to the packaging in Debian, I guess...
Owner

Yes, this applies to deb packaging. The file is installed during build, but it is not packaged in any deb package.

It should also be noted that the file name is not appropriate since it is installed in the bin folder. It should contain the prefix tde.

Yes, this applies to deb packaging. The file is *installed* during build, but it is not packaged in any deb package. It should also be noted that the file name is not appropriate since it is installed in the `bin` folder. It should contain the prefix `tde`.
Owner

Btw, Matias could you rebase this against latest master? Then I would merge the PR in.

Btw, Matias could you rebase this against latest master? Then I would merge the PR in.
selk commented 4 years ago
Poster
Collaborator

@MicheleC Done. :-)

@MicheleC Done. :-)
selk commented 4 years ago
Poster
Collaborator

@SlavekB Yes, it is a good idea to rename it.

@SlavekB Yes, it is a good idea to rename it.
Owner

Hi Matias,

it seems the commit is still not rebased on top of master.

Please try this:

git fetch --all --prune
git checkout feat/script-enhancement-release_notes
git rebase -S origin/master
git log HEAD --oneline -n 10 --decorate  ## please verify the commit is now on top of master
git push -f origin HEAD
Hi Matias,<br/> it seems the commit is still not rebased on top of master.<br/> Please try this: ``` git fetch --all --prune git checkout feat/script-enhancement-release_notes git rebase -S origin/master git log HEAD --oneline -n 10 --decorate ## please verify the commit is now on top of master git push -f origin HEAD ```
selk commented 4 years ago
Poster
Collaborator

Hi @MicheleC Thanks for the instructions. Could you check?.

Hi @MicheleC Thanks for the instructions. Could you check?.
MicheleC closed this pull request 4 years ago
MicheleC deleted branch feat/script-enhancement-release_notes 4 years ago
MicheleC added this to the R14.0.8 release milestone 4 years ago
Owner

Thanks, merged already.

Thanks, merged already.
The pull request has been merged as ed1d5dea33.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#129
Loading…
There is no content yet.