TDE
/
tdebase
9
3
Fork 1
Code Issues 119 Pull Requests 10 Releases Wiki Activity
Labels Milestones

Fix units of battery values in Device Manager. #130

Merged
SlavekB merged 1 commits from fix/unify-units-of-battery-values into master 4 years ago
Conversation 5 Commits 1 Files Changed 1
SlavekB commented 4 years ago
Owner

Previously it was not clear whether the units in tdehwlib are
in Wh and W or Ah and A. Now the units are always Ah and A.

This is related to issue TDE/tdelibs#68.

Previously it was not clear whether the units in tdehwlib are in Wh and W or Ah and A. Now the units are always Ah and A. This is related to issue TDE/tdelibs#68.
SlavekB added this to the R14.0.8 release milestone 4 years ago
SlavekB added the PR/rfc label 4 years ago
Ghost commented 4 years ago

The unit conversion to Ah/A is working.
Here are screenshots.

without path:

The unit conversion to Ah/A is working. Here are screenshots. without path:
battery_without_patch.png
154 KiB
Ghost commented 4 years ago

with the path:

with the path:
battery1_with_patch.png
143 KiB
Chris commented 4 years ago
Collaborator

Works for me, besides the problem with the decimal separator.

Just verified what my battery has for values.

Otherwise good work. 👍

EDIT: Is there a reason the remaining time to load is shown in seconds instead of minutes? 😅

Works for me, besides the problem with the decimal separator. Just verified what my battery has for values. Otherwise good work. :+1: EDIT: Is there a reason the remaining time to load is shown in seconds instead of minutes? :sweat_smile:
MicheleC commented 4 years ago
Owner

Looks good to me too.

Looks good to me too.
MicheleC commented 4 years ago
Owner

EDIT: Is there a reason the remaining time to load is shown in seconds instead of minutes? 😅

It probably makes more sense to have this time in minutes. Perhaps you can work on a PR when you have free time?

> EDIT: Is there a reason the remaining time to load is shown in seconds instead of minutes? :sweat_smile: It probably makes more sense to have this time in minutes. Perhaps you can work on a PR when you have free time?
SlavekB removed the PR/rfc label 4 years ago
SlavekB closed this pull request 4 years ago
SlavekB deleted branch fix/unify-units-of-battery-values 4 years ago
The pull request has been merged as 0215a0e712.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.8 release
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Blocks
#68 tdehwlib: Shuffled units of battery values
TDE/tdelibs
Reference: TDE/tdebase#130
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/unify-units-of-battery-values'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes