r14-xdg-update: Enhance script location, replace bashishm, minor changes #136
Manually merged
selk
merged 1 commits from feat/script-enhancement-r14-xdg-update into master 4 years ago
No reviewers
No Label
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TDE/tdebase#136
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/script-enhancement-r14-xdg-update'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Determining TDEDIR in this script may be easier – see comment.
# Let's check if this script is called from the Debian alternatives# See: https://wiki.debian.org/DebianAlternativesif [ "$(readlink -- "$0")" = "/etc/alternatives/x-session-manager" ]Value of
$(readlink -- "$0")forr14-xdg-updatescript can never be/etc/alternatives/x-session-manager. So this part of the code is not applicable here.@SlavekB Okay, good to know (I was in doubt). I've removed that code simplyfing the location with dirname.
Looks good now. Thanks Matias, both Slavek and I had the same doubt about that piece of code 😉
Hi @MicheleC :-)
Thanks for merge it, and thanks to SlavekB for review it. Now a question, the script "migratekde3" contains some same parts as the r14-xdg-update script, I should do the same for it?.
Sounds like a good plan Matias. Again that script will not be called by a DM, so there is no need to check for debian alternatives.
09a76446bb.