Broken file mask in kcontrol's color profile selection #143

Closed
opened 4 years ago by chytrex · 8 comments

Basic information

  • TDE version: R14.1.x
  • Distribution: Devuan Ascii
  • Hardware: Amd64

Description

There are two lines as one file mask delimited by \n, which of course does not match anything.
...

Steps to reproduce

  1. Open kcontrol > Periphetals > Color profile
  2. Try to select ICC/ICM profile

Screenshots

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: R14.1.x <!-- such as R14.0.6 - see tde-config -v --> - Distribution: Devuan Ascii <!-- such as Debian Stretch - see lsb_release -sd --> - Hardware: Amd64 <!-- amd64 / i386 / armhf / ... --> <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description There are two lines as one file mask delimited by \n, which of course does not match anything. ... ## Steps to reproduce 1. Open kcontrol > Periphetals > Color profile 2. Try to select ICC/ICM profile ## Screenshots <!-- If it seems useful, please provide provide one or more screenshots. -->
Collaborator

reproducable in 14.1

reproducable in 14.1
Owner

confirmed here too

confirmed here too
Owner

confirmed here too

confirmed here too
Owner

Also confirmed on R14.0.8. Unfortunately, it is too late for the fix to be included in R14.0.8 since the final tdebase packages are already built.

Also confirmed on R14.0.8. Unfortunately, it is too late for the fix to be included in R14.0.8 since the final tdebase packages are already built.
Owner

PR #144 propose a possible solution. I have not been able to find a better one. I guess the code builder from .ui files, simply assigned the string value without any parsing, as if would do for any other string. So setting the filter using the "setFilter()" function from code seems the correct way since it will part the passed string.

PR #144 propose a possible solution. I have not been able to find a better one. I guess the code builder from .ui files, simply assigned the string value without any parsing, as if would do for any other string. So setting the filter using the "setFilter()" function from code seems the correct way since it will part the passed string.
Owner

PR #144 is discarded. Slavek found a better solution.

PR #144 is discarded. Slavek found a better solution.
Owner

Issue fixed in master. The same fix will be backported to R14.0.9 after the release of R14.0.8 is over. Will keep this issue open till then.

Issue fixed in master. The same fix will be backported to R14.0.9 after the release of R14.0.8 is over. Will keep this issue open till then.
MicheleC added this to the R14.0.9 release milestone 4 years ago
Owner

Backport done.

Backport done.
MicheleC closed this issue 4 years ago
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#143
Loading…
There is no content yet.