Button labels in TCC change after accessing Input Actions module #160

Open
opened 4 years ago by jstolarek · 11 comments
Collaborator

Basic information

  • TDE version: R14.0.9
  • Distribution: Debian Buster
  • Hardware: amd64

Description

A most peculiar bug happens on Polish version of TDE and I have no idea whether the same happens on other language versions. Open TCC and go to, for example, System Administration -> Login Manager. Notice the labels on buttons in lower right corner. In Polish localisation these are "Zastosuj" (Apply) and "Porzuć" (Reset). Now go to Locale and Accessability -> Input Actions and the "Porzuć" button changes its label to "Powtórz" (Repeat/Redo) and remains that way until TCC is restarted. See attached screenshots.

## Basic information - TDE version: R14.0.9 - Distribution: Debian Buster - Hardware: amd64 ## Description A most peculiar bug happens on Polish version of TDE and I have no idea whether the same happens on other language versions. Open TCC and go to, for example, System Administration -> Login Manager. Notice the labels on buttons in lower right corner. In Polish localisation these are "Zastosuj" (Apply) and "Porzuć" (Reset). Now go to Locale and Accessability -> Input Actions and the "Porzuć" button changes its label to "Powtórz" (Repeat/Redo) and remains that way until TCC is restarted. See attached screenshots.
jstolarek added the SL/normal label 4 years ago
Collaborator

Here the language is Bulgarian and the labels are consistent. It should be something with the translation perhaps.

Here the language is Bulgarian and the labels are consistent. It should be something with the translation perhaps.
Poster
Collaborator

Thanks for checking. I am confident that I am able to modify the Polish translation files to mask the problem (i.e. change the translations to be the same), but I guess there is a deeper underlying cause here.

Thanks for checking. I am confident that I am able to modify the Polish translation files to mask the problem (i.e. change the translations to be the same), but I guess there is a deeper underlying cause here.
Owner

In English the labels are "Apply" and "Reset" in both cases, so it definitely seems related to the translation in use.

EDIT: TCC is a common container for controls modules, so those buttons are pretty standard. The available buttons depends on the module in use. Perhaps one of those module is using a different button and the translation highlight an issue? @jstolarek is that the only module wrong?

In English the labels are "Apply" and "Reset" in both cases, so it definitely seems related to the translation in use. EDIT: TCC is a common container for controls modules, so those buttons are pretty standard. The available buttons depends on the module in use. Perhaps one of those module is using a different button and the translation highlight an issue? @jstolarek is that the only module wrong?
Poster
Collaborator

Yes, Input Actions is the only module that causes this.

Perhaps one of those module is using a different button and the translation highlight an issue?

The surprising thing about the issue is that once you access the Input Actions module and the button label gets switched, it remains switched even in other modules. So if I go back to Login Manager the button now says "Powtórz", even though it used to say "Porzuć". That persistent change across modules is the most suspicious thing about this bug.

Another question is: if these buttons are standard then why there are different definitions of them and not just one?

Yes, Input Actions is the only module that causes this. > Perhaps one of those module is using a different button and the translation highlight an issue? The surprising thing about the issue is that once you access the Input Actions module and the button label gets switched, it remains switched even in other modules. So if I go back to Login Manager the button now says "Powtórz", even though it used to say "Porzuć". That persistent change across modules is the most suspicious thing about this bug. Another question is: if these buttons are standard then why there are different definitions of them and not just one?
Owner

The surprising thing about the issue is that once you access the Input Actions module and the button label gets switched, it remains switched even in other modules. So if I go back to Login Manager the button now says "Powtórz", even though it used to say "Porzuć". That persistent change across modules is the most suspicious thing about this bug.

Uhm... this switch acrossed different modules is suspicious. As in I understand if one module is different for some reasons, but when you move back to another module it should not show the switched string.... sounds like something fishy is going on there.

Another question is: if these buttons are standard then why there are different definitions of them and not just one?

In TDE there is a set of standard actions and buttons and they are used in many places. I was thinking one module was using a different button with the same Elglish name (but different translation), but after your last post that would not explain it. The persistent switch is really weird.

> The surprising thing about the issue is that once you access the Input Actions module and the button label gets switched, it remains switched even in other modules. So if I go back to Login Manager the button now says "Powtórz", even though it used to say "Porzuć". That persistent change across modules is the most suspicious thing about this bug. Uhm... this switch acrossed different modules is suspicious. As in I understand if one module is different for some reasons, but when you move back to another module it should not show the switched string.... sounds like something fishy is going on there. > Another question is: if these buttons are standard then why there are different definitions of them and not just one? In TDE there is a set of standard actions and buttons and they are used in many places. I was thinking one module was using a different button with the same Elglish name (but different translation), but after your last post that would not explain it. The persistent switch is really weird.
Poster
Collaborator

when you move back to another module it should not show the switched string

Precisely. Sorry if I didn't make that clear in my original report. I'm attaching a screenshot of Login Manager module after opening the Input Actions module first. Compare it to tcc-before.png attached to the bug report.

there is a set of standard actions and buttons and they are used in many places. (...) same Elglish name (but different translation)

The two parts separated by (...) somewhat contradict each other. It seems as if there were two "Reset" buttons defined in the set of standard buttons. Otherwise, how is it possible to attach two different translations?

> when you move back to another module it should not show the switched string Precisely. Sorry if I didn't make that clear in my original report. I'm attaching a screenshot of Login Manager module after opening the Input Actions module first. Compare it to [tcc-before.png](https://mirror.git.trinitydesktop.org/gitea/attachments/0310d0c2-f837-4a74-b4f9-22812ed99c81) attached to the bug report. > there is a set of standard actions and buttons and they are used in many places. (...) same Elglish name (but different translation) The two parts separated by (...) somewhat contradict each other. It seems as if there were two "Reset" buttons defined in the set of standard buttons. Otherwise, how is it possible to attach two different translations?
Owner

You are right, it is contracdictory. The strings would have to be different, like for example "reset" and "cancel" or something like that.
Are you able to do a test switching to the English language and see if you see the same issue there?

You are right, it is contracdictory. The strings would have to be different, like for example "reset" and "cancel" or something like that. Are you able to do a test switching to the English language and see if you see the same issue there?
Poster
Collaborator

Are you able to do a test switching to the English language and see if you see the same issue there?

I suppose I could try later.

> Are you able to do a test switching to the English language and see if you see the same issue there? I suppose I could try later.
Owner

I installed Polish language and I can confirm the bug. I tried also in Italian and as well the bug showed up. I think that Input action module does something to change the text of the button and then the button remains in the status it was, since TCC would create the button when TCC is open. That's my best guess so far.

I installed Polish language and I can confirm the bug. I tried also in Italian and as well the bug showed up. I think that Input action module does something to change the text of the button and then the button remains in the status it was, since TCC would create the button when TCC is open. That's my best guess so far.
Poster
Collaborator

@MicheleC, do you still want me to try switching to English?

@MicheleC, do you still want me to try switching to English?
Owner

@MicheleC, do you still want me to try switching to English?

No need, I can reproduce the issue here.

> @MicheleC, do you still want me to try switching to English? No need, I can reproduce the issue here.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#160
Loading…
There is no content yet.