Fixed random SEGV in Konqueror caused by klipper when the clipboard was being cleared. #178
Merged
MicheleC
merged 1 commits from issue/147 into master 3 years ago
No reviewers
No Label
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TDE/tdebase#178
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'issue/147'
Deleting a branch is permanent. It CANNOT be undone. Continue?
This resolves issue #147.
// Using a direct call may crash another application that was// changing the clipboard at the same time.bSavedSelectionMode = selectionMode;m_setClipboardTimer.start(0, TRUE);Could it be easier to use a singleShot timer call instead of creating a timer? Something like:
It could, I hadn't thought of that. But ultimately I think it would be less efficient. Single shot calls still create a timer internally and later destroy it once done. Since setting the clipboard could be a common operation in a user session, a permanent dedicated timer would have less overhead, being created only once.
Yeah, thank you, that makes sense.
e588c507dbto014d4c77c83 years agoWith the original code, there were still some crashes here and there. With the new commit, I have not been able to crash Konqueror any longer.
014d4c77c8tob7e3eef5913 years agoAdded check for empty clipboard after the short delay, as discussed with Slavek.
b7e3eef591toe2158a0f0b3 years agoe2158a0f0binto master 3 years agoe2158a0f0b.