TDE
/
tdebase
9
4
Fork 1
Code Issues 116 Pull Requests 10 Releases Wiki Activity
Labels Milestones

Use new 'window_duplicate' icon in tdelibs instead of 'window_list' #197

Merged
MicheleC merged 1 commits from feat/window_icon into master 3 years ago
Conversation 9 Commits 1 Files Changed 12
MicheleC commented 3 years ago
Owner

@cethyel @SlavekB
Please test and let me know if you see any issue with this.

For Debian based distros, to be tested with TDE/tde-packaging#76

@cethyel @SlavekB Please test and let me know if you see any issue with this. For Debian based distros, to be tested with TDE/tde-packaging#76
MicheleC added 1 commit 3 years ago
6408069d61
Use new 'window_duplicate' icon in tdelibs
SlavekB added the PR/update-trans label 3 years ago
MicheleC added this to the R14.0.10 release milestone 3 years ago
MicheleC requested review from SlavekB 3 years ago
MicheleC requested review from Ghost 3 years ago
MicheleC commented 3 years ago
Poster
Owner

Merging of this PR will need to be performed together with an equivalent merge in tde-i18n to avoid fuzzy tranlations

Merging of this PR will need to be performed together with an equivalent merge in tde-i18n to avoid fuzzy tranlations
SlavekB commented 3 years ago
Owner

In addition to the update in tde-i18n, it will be advisable also to rename window_list icons in IconThemes in tdeartwork.

In addition to the update in `tde-i18n`, it will be advisable also to rename `window_list` icons in IconThemes in `tdeartwork`.
MicheleC commented 3 years ago
Poster
Owner

In addition to the update in tde-i18n, it will be advisable also to rename window_list icons in IconThemes in tdeartwork.

Yes, the rename is required in a few themes 👍

I will prepare PRs in coming days.

> In addition to the update in `tde-i18n`, it will be advisable also to rename `window_list` icons in IconThemes in `tdeartwork`. Yes, the rename is required in a few themes :+1: I will prepare PRs in coming days.
MicheleC commented 3 years ago
Poster
Owner

PR for ksplash-moodin-enginer is also required.

PR for ksplash-moodin-enginer is also required.
MicheleC commented 3 years ago
Poster
Owner

PR for tdeaccessibility is also required

PR for tdeaccessibility is also required
MicheleC commented 3 years ago
Poster
Owner

All PRs are ready

All PRs are ready - [x] TDE/tde-packaging#76 - [x] TDE/tde-i18n#33 - [x] TDE/ksplash-engine-moodin#4 - [x] TDE/tdeartwork#15 - [x] TDE/tdeaccessibility#7
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

Originally I hesitate to keep both icons, but windows_list is installed as an application icon, which is not appropriate. Using icon for window_duplicate action sounds like a good idea.

Originally I hesitate to keep both icons, but `windows_list` is installed as an application icon, which is not appropriate. Using icon for `window_duplicate` action sounds like a good idea.
Ghost commented 3 years ago

It builds fine here, ack does not report any more window_list occurences than you already found and I can see the window_duplicate icon in kicker. I assume everything is fine.

It builds fine here, ack does not report any more window_list occurences than you already found and I can see the window_duplicate icon in kicker. I assume everything is fine.
Ghost refused to review 3 years ago
MicheleC merged commit 6408069d61 into master 3 years ago
MicheleC deleted branch feat/window_icon 3 years ago
MicheleC commented 3 years ago
Poster
Owner

@SlavekB @cethyel
Thanks both for testing. Greg, not sure why you were not in the reviewer list, I am quite sure I had added you as well. In any case thanks.

@SlavekB @cethyel Thanks both for testing. Greg, not sure why you were not in the reviewer list, I am quite sure I had added you as well. In any case thanks.
Ghost commented 3 years ago

Greg, not sure why you were not in the reviewer list, I am quite sure I had added you as well.

Sure, you did add me as a reviewer but when I was looking to approve I accidentally removed myself from the reviewers. 😊

>Greg, not sure why you were not in the reviewer list, I am quite sure I had added you as well. Sure, you did add me as a reviewer but when I was looking to approve I accidentally removed myself from the reviewers. :blush:
👍 1

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as 6408069d61.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.10 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#197
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/window_icon'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes