kicker/naughtyapplet: Smiley is cropped to the bottom right in kicker panel #213
Closed
opened 2 years ago by hunter0one
·
6 comments
Loading…
Reference in new issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Basic information
Description
The smiley face is cropped to the bottom right which I think is not intentional.
Steps to reproduce
Screenshots
Confirmed, also in case the taskbar is vertical.
This applet has a button of a fixed size 20x20. Still, to set the icon, BarIcon() is used, which resizes the icon according to the Toolbar Icon Size, whatever the user set that (here and here).
There are two possible solutions — either remove these BarIcon calls or make 20x20 resizeable.
Nice research @blu.256. The taskbar can have different sizes (both predefined or custom) so a fixed size is probably not the best choice. IMO we should look at resizing the icon based on the actual taskbar icon size.
Perhaps just having the icon 16x16 would be good enough, since that is the minimum icon size??
I think that resizing the icon according to taskbar height (or width, in vertical mode) would be the better choice, because this is what other Kicker icons do (quick launch) and this is probably what one who resizes their panel would expect. A fixed size would fit system tray icons better than a Kicker applet.
Sounds good, let's go for resizing the icon.
Solved with commit
e22588e97d
.