kicker/naughtyapplet: Smiley is cropped to the bottom right in kicker panel #213

Closed
opened 2 years ago by hunter0one · 6 comments
Collaborator

Basic information

  • TDE version: R14.0.10
  • APP version: R14.0.10
  • Distribution:
  • System: FreeBSD 13.0-STABLE
  • Hardware: amd64
  • Compiler: Clang 11.0.1

Description

The smiley face is cropped to the bottom right which I think is not intentional.

Steps to reproduce

  1. Add Runaway Process Catcher to the kicker panel

Screenshots

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: R14.0.10 - APP version: R14.0.10 - Distribution: <!-- such as Debian Buster - see lsb_release -sd --> - System: FreeBSD 13.0-STABLE - Hardware: amd64 - Compiler: Clang 11.0.1 <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description The smiley face is cropped to the bottom right which I think is not intentional. ## Steps to reproduce 1. Add Runaway Process Catcher to the kicker panel ## Screenshots ![](https://i.postimg.cc/ZnrzDgH8/snapshot10.png)
SlavekB added the SL/minor label 2 years ago
Owner

Confirmed, also in case the taskbar is vertical.

Confirmed, also in case the taskbar is vertical.
Collaborator

This applet has a button of a fixed size 20x20. Still, to set the icon, BarIcon() is used, which resizes the icon according to the Toolbar Icon Size, whatever the user set that (here and here).

There are two possible solutions — either remove these BarIcon calls or make 20x20 resizeable.

This applet has a button of a fixed size [20x20](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/kicker/applets/naughty/NaughtyApplet.cpp#L70). Still, to set the icon, BarIcon() is used, which resizes the icon according to the Toolbar Icon Size, whatever the user set that ([here](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/kicker/applets/naughty/NaughtyApplet.cpp#L151) and [here](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/kicker/applets/naughty/NaughtyApplet.cpp#L153)). There are two possible solutions — either remove these BarIcon calls or make 20x20 resizeable.
Owner

Nice research @blu.256. The taskbar can have different sizes (both predefined or custom) so a fixed size is probably not the best choice. IMO we should look at resizing the icon based on the actual taskbar icon size.
Perhaps just having the icon 16x16 would be good enough, since that is the minimum icon size??

Nice research @blu.256. The taskbar can have different sizes (both predefined or custom) so a fixed size is probably not the best choice. IMO we should look at resizing the icon based on the actual taskbar icon size. Perhaps just having the icon 16x16 would be good enough, since that is the minimum icon size??
Collaborator

I think that resizing the icon according to taskbar height (or width, in vertical mode) would be the better choice, because this is what other Kicker icons do (quick launch) and this is probably what one who resizes their panel would expect. A fixed size would fit system tray icons better than a Kicker applet.

I think that resizing the icon according to taskbar height (or width, in vertical mode) would be the better choice, because this is what other Kicker icons do (quick launch) and this is probably what one who resizes their panel would expect. A fixed size would fit system tray icons better than a Kicker applet.
Owner

Sounds good, let's go for resizing the icon.

Sounds good, let's go for resizing the icon.
blu.256 referenced this issue from a commit 2 years ago
blu.256 referenced this issue from a commit 2 years ago
Collaborator

Solved with commit e22588e97d.

Solved with commit e22588e97d.
blu.256 closed this issue 2 years ago
blu.256 added this to the R14.0.11 release milestone 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#213
Loading…
There is no content yet.