TDE
/
tdebase
9
4
Fork 1
Code Issues 115 Pull Requests 10 Releases Wiki Activity
Labels Milestones

Fixed FTBFS with gcc 4.8 when using c++11 standard. #223

Merged
MicheleC merged 1 commits from fix/ftbfs/c++11 into master 3 years ago
Conversation 2 Commits 1 Files Changed 1
MicheleC commented 3 years ago
Owner

When building with gcc 4.8.4 (Ubuntu Trusty) with -std=c++11, there was FTBFS caused by conflicting definitions of abs(). Removing "using namespace std;" solves the problem.
I believe the additional #ifdef for OpenBSD was a previous attempt to prevent such issue on earlier distribution (see commit 44654c9af5 from Francois, the description seems exactly what I thought).

When building with gcc 4.8.4 (Ubuntu Trusty) with -std=c++11, there was FTBFS caused by conflicting definitions of abs(). Removing "using namespace std;" solves the problem. I believe the additional #ifdef for OpenBSD was a previous attempt to prevent such issue on earlier distribution (see commit 44654c9af5 from Francois, the description seems exactly what I thought).
MicheleC added 1 commit 3 years ago
064d38f2c8
Fixed FTBFS with gcc 4.8 when using c++11 standard.
MicheleC added this to the R14.0.11 release milestone 3 years ago
MicheleC requested review from SlavekB 3 years ago
MicheleC commented 3 years ago
Poster
Owner

@SlavekB could you test build in FreeBSD to see if you have any issue?
@Francois not sure if you are building for OpenBSD, but if so could you give it a test?

Both, please use -std=c++11 as additional CXXFLAGS for the compiler.

@SlavekB could you test build in FreeBSD to see if you have any issue? @Francois not sure if you are building for OpenBSD, but if so could you give it a test? Both, please use -std=c++11 as additional CXXFLAGS for the compiler.
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

Build on FreeBSD is successfull.

Build on FreeBSD is successfull.
MicheleC merged commit 064d38f2c8 into master 3 years ago
MicheleC deleted branch fix/ftbfs/c++11 3 years ago
MicheleC commented 3 years ago
Poster
Owner

Thanks for testing Slavek.

Thanks for testing Slavek.

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as 064d38f2c8.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#223
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/ftbfs/c++11'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes